Auto merge of #12972 - ehuss:windows-gnu-ignore-json-target, r=epage

bors · bors · commit 360059edcdd3 · 2023-11-14T03:21:41.000Z
Ignore changing_spec_relearns_crate_types on windows-gnu This disables the `custom_target::changing_spec_relearns_crate_types` on windows-gnu targets for the same reason as #12763. The update to LLVM 17 has started to cause lld to crash when using a custom target. cc rust-lang/rust#115985 I surveyed the rest of the testsuite, and I don't see any other tests that perform linking with custom targets.
diff --git a/tests/testsuite/custom_target.rs b/tests/testsuite/custom_target.rs
@@ -178,6 +178,8 @@ fn changing_spec_rebuilds() {
 }
 
 #[cargo_test(nightly, reason = "requires features no_core, lang_items")]
+// This is randomly crashing in lld. See https://github.com/rust-lang/rust/issues/115985
+#[cfg_attr(all(windows, target_env = "gnu"), ignore = "windows-gnu lld crashing")]
 fn changing_spec_relearns_crate_types() {
     // Changing the .json file will invalidate the cache of crate types.
     let p = project()

Original file line number	Diff line number	Diff line change
`@@ -178,6 +178,8 @@ fn changing_spec_rebuilds() {`
`178`	`178`	`}`
`179`	`179`
`180`	`180`	`#[cargo_test(nightly, reason = "requires features no_core, lang_items")]`
	`181`	`+// This is randomly crashing in lld. See https://github.com/rust-lang/rust/issues/115985`
	`182`	`+#[cfg_attr(all(windows, target_env = "gnu"), ignore = "windows-gnu lld crashing")]`
`181`	`183`	`fn changing_spec_relearns_crate_types() {`
`182`	`184`	`// Changing the .json file will invalidate the cache of crate types.`
`183`	`185`	`let p = project()`