Unlink WEBrick::HTTPUtils.#escape_form because the page is missing #2113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
リンクを消してしまうと戻し忘れると思うので、リンク先を作成する方向で対応したいです。 |
hanachin
reviewed
Mar 3, 2020
| [[m:CGI.escape]], | ||
| [[m:URI.encode_www_form_component]], | ||
| [[m:WEBrick::HTTPUtils.#escape_form]], | ||
| WEBrick::HTTPUtils.#escape_form, |
Member
There was a problem hiding this comment.
これるりまではコメントアウトされてるようですね
doctree/refm/api/src/webrick/httputils/HTTPUtils
Lines 115 to 116 in 2ff36ef
rdocにはエントリありました
https://docs.ruby-lang.org/en/2.7.0/WEBrick/HTTPUtils.html#method-i-escape_form
「内部で使われているだけのメソッドと定数を削除。 」と 4648051 のコミットで削除されていますが、実際には使われているようですね
% csearch -f '\.rb$' '\.escape_form'
/mnt/gems/gem-codesearch/latest-gem/Chrononaut-echoe-3.0.2/lib/echoe/client.rb: WEBrick::HTTPUtils.escape_form(k.to_s) + "\""
/mnt/gems/gem-codesearch/latest-gem/aws-sdk-s3-1.59.0/lib/aws-sdk-s3/legacy_signer.rb: # WEBrick::HTTPUtils.escape_form(s),
/mnt/gems/gem-codesearch/latest-gem/cinch-lastfm-ng-0.1.3/lib/cinch/plugins/lastfm.rb: doop = WEBrick::HTTPUtils.escape_form(artist)
/mnt/gems/gem-codesearch/latest-gem/cinch-lastfm-ng-0.1.3/lib/cinch/plugins/lastfm.rb: pood = WEBrick::HTTPUtils.escape_form(title)
/mnt/gems/gem-codesearch/latest-gem/cinch-lastfm-ng-0.1.3/lib/cinch/plugins/lastfm.rb: doop = WEBrick::HTTPUtils.escape_form(artist)
/mnt/gems/gem-codesearch/latest-gem/cinch-lastfm-ng-0.1.3/lib/cinch/plugins/lastfm.rb: artist = WEBrick::HTTPUtils.escape_form(artist)
/mnt/gems/gem-codesearch/latest-gem/elliottcable-echoe-3.1.3/lib/echoe/client.rb: WEBrick::HTTPUtils.escape_form(k.to_s) + "\""
/mnt/gems/gem-codesearch/latest-gem/eric-mechanize-0.9.3.20090623142847/lib/www/mechanize/util.rb: [WEBrick::HTTPUtils.escape_form(k.to_s),
/mnt/gems/gem-codesearch/latest-gem/eric-mechanize-0.9.3.20090623142847/lib/www/mechanize/util.rb: WEBrick::HTTPUtils.escape_form(v.to_s)].join("=")
/mnt/gems/gem-codesearch/latest-gem/fauna-echoe-3.2/lib/echoe/client.rb: WEBrick::HTTPUtils.escape_form(k.to_s) + "\""
/mnt/gems/gem-codesearch/latest-gem/gemrage-1.0.0/vendor/ruby/1.8/gems/rubyforge-2.0.4/lib/rubyforge/client.rb: WEBrick::HTTPUtils.escape_form(k.to_s) + "\""
/mnt/gems/gem-codesearch/latest-gem/gemrage-1.0.0/vendor/ruby/1.8/gems/rubyforge-2.0.4/lib/rubyforge/client.rb: k && [ WEBrick::HTTPUtils.escape_form(k.to_s),
/mnt/gems/gem-codesearch/latest-gem/gemrage-1.0.0/vendor/ruby/1.8/gems/rubyforge-2.0.4/lib/rubyforge/client.rb: WEBrick::HTTPUtils.escape_form(v.to_s) ].join('=')
/mnt/gems/gem-codesearch/latest-gem/gonzui-1.2/lib/gonzui/webapp/markup.rb: query_string = sprintf("%s:%s", tt, HTTPUtils.escape_form(text))
/mnt/gems/gem-codesearch/latest-gem/gonzui-1.2/lib/gonzui/webapp/uri.rb: HTTPUtils.escape_form(search_query.string_without_properties))
/mnt/gems/gem-codesearch/latest-gem/gonzui-1.2/lib/gonzui/webapp/uri.rb: param = sprintf("%s=%s", qv.short_name, HTTPUtils.escape_form(value.to_s))
/mnt/gems/gem-codesearch/latest-gem/horseman-0.0.5/vendor/ruby/1.9.1/gems/rubyforge-2.0.4/lib/rubyforge/client.rb: WEBrick::HTTPUtils.escape_form(k.to_s) + "\""
/mnt/gems/gem-codesearch/latest-gem/horseman-0.0.5/vendor/ruby/1.9.1/gems/rubyforge-2.0.4/lib/rubyforge/client.rb: k && [ WEBrick::HTTPUtils.escape_form(k.to_s),
/mnt/gems/gem-codesearch/latest-gem/horseman-0.0.5/vendor/ruby/1.9.1/gems/rubyforge-2.0.4/lib/rubyforge/client.rb: WEBrick::HTTPUtils.escape_form(v.to_s) ].join('=')
/mnt/gems/gem-codesearch/latest-gem/ivanvc-logstash-input-s3-3.1.1.4/vendor/local/gems/aws-sdk-core-2.3.22/lib/aws-sdk-core/signers/s3.rb: # WEBrick::HTTPUtils.escape_form(s),
/mnt/gems/gem-codesearch/latest-gem/knu-mechanize-0.9.3.20090623142847/lib/www/mechanize/util.rb: [WEBrick::HTTPUtils.escape_form(k.to_s),
/mnt/gems/gem-codesearch/latest-gem/knu-mechanize-0.9.3.20090623142847/lib/www/mechanize/util.rb: WEBrick::HTTPUtils.escape_form(v.to_s)].join("=")
/mnt/gems/gem-codesearch/latest-gem/mack-0.8.3.1/lib/gems/rubyforge-1.0.1/lib/rubyforge/client.rb: WEBrick::HTTPUtils.escape_form(k.to_s) + "\""
/mnt/gems/gem-codesearch/latest-gem/mack-0.8.3.1/lib/gems/rubyforge-1.0.1/lib/rubyforge/client.rb: k && [ WEBrick::HTTPUtils.escape_form(k.to_s),
/mnt/gems/gem-codesearch/latest-gem/mack-0.8.3.1/lib/gems/rubyforge-1.0.1/lib/rubyforge/client.rb: WEBrick::HTTPUtils.escape_form(v.to_s) ].join('=')
/mnt/gems/gem-codesearch/latest-gem/mechanize-ntlm-0.9.1/lib/www/mechanize/util.rb: [WEBrick::HTTPUtils.escape_form(k.to_s),
/mnt/gems/gem-codesearch/latest-gem/mechanize-ntlm-0.9.1/lib/www/mechanize/util.rb: WEBrick::HTTPUtils.escape_form(v.to_s)].join("=")
/mnt/gems/gem-codesearch/latest-gem/ric-0.13.0/vendor/bundle/ruby/2.5.0/gems/rubyforge-2.0.4/lib/rubyforge/client.rb: WEBrick::HTTPUtils.escape_form(k.to_s) + "\""
/mnt/gems/gem-codesearch/latest-gem/ric-0.13.0/vendor/bundle/ruby/2.5.0/gems/rubyforge-2.0.4/lib/rubyforge/client.rb: k && [ WEBrick::HTTPUtils.escape_form(k.to_s),
/mnt/gems/gem-codesearch/latest-gem/ric-0.13.0/vendor/bundle/ruby/2.5.0/gems/rubyforge-2.0.4/lib/rubyforge/client.rb: WEBrick::HTTPUtils.escape_form(v.to_s) ].join('=')
/mnt/gems/gem-codesearch/latest-gem/rsanheim-echoe-3/lib/echoe/client.rb: WEBrick::HTTPUtils.escape_form(k.to_s) + "\""
/mnt/gems/gem-codesearch/latest-gem/rubyforge-2.0.4/lib/rubyforge/client.rb: WEBrick::HTTPUtils.escape_form(k.to_s) + "\""
/mnt/gems/gem-codesearch/latest-gem/rubyforge-2.0.4/lib/rubyforge/client.rb: k && [ WEBrick::HTTPUtils.escape_form(k.to_s),
/mnt/gems/gem-codesearch/latest-gem/rubyforge-2.0.4/lib/rubyforge/client.rb: WEBrick::HTTPUtils.escape_form(v.to_s) ].join('=')
/mnt/gems/gem-codesearch/latest-gem/search_do-0.3.0/lib/estraier_admin.rb: params.map{|k,v| "#{k}=#{WEBrick::HTTPUtils.escape_form(v.to_s)}" }.join('&')
/mnt/gems/gem-codesearch/latest-gem/technicalpickles-echoe-3/lib/echoe/client.rb: WEBrick::HTTPUtils.escape_form(k.to_s) + "\""
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.ruby-lang.org/ja/latest/method/URI/s/encode.html に
WEBrick::HTTPUtils.#escape_formへのリンクがあるのですが、ページが未作成なので（参考）、リンクをクリックしても404になります。ですので、ページが作成されるまでリンクを外しておいた方がいいのでは？と思いました。
（ただし、 https://docs.ruby-lang.org/ja/latest/class/WEBrick=3a=3aHTTPUtils.html を見ても
escape_formが見当たらないので、結局読み手は困惑しそうですが・・・）