Enhances RSpec/MultipleExpectations message to suggest aggregate_failure #2132
+23
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydah
reviewed
Nov 12, 2025
Member
ydah
left a comment
ydah
left a comment
There was a problem hiding this comment.
Thank you for your work. But I believe this change is not appropriate, as the offense message does not apply when aggregate_failures: false is used.
Author
|
No problem, i get that. Would adapting the message conditionally make you reconsider? EDIT: Just made a small commit to show the message conditionally, I leave weather it's worth or not to your appreciation. Best ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the RSpec/MultipleExpectations cop error message to proactively suggest using aggregate_failures as an alternative to splitting specs.
Before:
Example has too many expectations [2/1].After:
Example has too many expectations [2/1]. Consider using `aggregate_failures` if these expectations are logically related.Motivation
Developers often encounter this cop and default to splitting specs without realizing aggregate_failures is available. This enhancement educates users at the point of encounter, improving both developer experience and test suite quality.
Changes
Updated error message in RSpec::MultipleExpectations cop
Updated all test cases to expect the new message format
Fixes #2131