Merge pull request #1573 from koic/fix_an_error_for_rails_select_map

Fix an error for `Rails/SelectMap`

Author: koic

changelog/fix_an_error_for_rails_select_map.md

@@ -0,0 +1 @@
+* [#1473](https://github.com/rubocop/rubocop-rails/pull/1473): Fix an error for `Rails/SelectMap` when `select(:column_name).map(&:column_name)` with parentheses. ([@koic][])

lib/rubocop/cop/rails/select_map.rb

@@ -58,9 +58,13 @@ def find_select_node(node, column_name)
 
         # rubocop:disable Metrics/AbcSize
         def autocorrect(corrector, select_node, node, preferred_method)
-          corrector.remove(select_node.parent.loc.dot)
-          corrector.remove(select_node.loc.selector.begin.join(select_node.source_range.end))
-          corrector.replace(node.loc.selector.begin.join(node.source_range.end), preferred_method)
+          if (parent = select_node.parent).loc?(:dot)
+            corrector.remove(parent.loc.dot)
+            corrector.remove(select_node.loc.selector.begin.join(select_node.source_range.end))
+            corrector.replace(node.loc.selector.begin.join(node.source_range.end), preferred_method)
+          else
+            corrector.replace(node, "#{select_node.receiver.source}.#{preferred_method}")
+          end
         end
         # rubocop:enable Metrics/AbcSize
 

spec/rubocop/cop/rails/select_map_spec.rb

@@ -12,6 +12,17 @@
     RUBY
   end
 
+  it 'registers an offense when using `select(:column_name).map(&:column_name)` with parentheses' do
+    expect_offense(<<~RUBY)
+      (Model.select(:column_name)).map(&:column_name)
+             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Use `pluck(:column_name)` instead of `select` with `map`.
+    RUBY
+
+    expect_correction(<<~RUBY)
+      Model.pluck(:column_name)
+    RUBY
+  end
+
   it "registers an offense when using `select('column_name').map(&:column_name)`" do
     expect_offense(<<~RUBY)
       Model.select('column_name').map(&:column_name)