Skip to content

Commit 330a8ed

Browse files
Copilotemiltin
andcommitted
Address TrafficControllerProxy review feedback
Co-authored-by: emiltin <66034+emiltin@users.noreply.github.com>
1 parent 6ed681f commit 330a8ed

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

lib/rsmp/node/supervisor/modules/connection.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ def retrieve_site_id(protocol)
8787

8888
def setup_proxy(proxy, settings, id)
8989
if proxy
90-
raise ConnectionError, "Site #{id} alredy connected from port #{proxy.port}" if proxy.connected?
90+
raise ConnectionError, "Site #{id} already connected from port #{proxy.port}" if proxy.connected?
9191

9292
proxy.revive settings
9393
else

lib/rsmp/node/supervisor/supervisor.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ def stop
6060

6161
def build_proxy(settings)
6262
proxy_type = settings[:proxy_type] || @supervisor_settings['proxy_type']
63-
return TrafficControllerProxy.new(settings) if proxy_type == 'tlc'
63+
return RSMP::TLC::TrafficControllerProxy.new(settings) if proxy_type == 'tlc'
6464

6565
SiteProxy.new settings
6666
end

lib/rsmp/tlc/traffic_controller_proxy.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ def fetch_signal_plan(options: {})
128128

129129
# Override close to clean up subscriptions.
130130
def close
131-
unsubscribe_all
131+
unsubscribe_all if respond_to?(:unsubscribe_all, true)
132132
super
133133
end
134134

0 commit comments

Comments
 (0)