Use 'type' instead of 'sxl' for determining proxy type

Separates concerns by using 'type' field for proxy determination while keeping 'sxl' for schema validation as suggested in review feedback.

Co-authored-by: emiltin <66034+emiltin@users.noreply.github.com>

Author: Copilot

config/supervisor.yaml

@@ -1,6 +1,7 @@
 port: 12111
 guest:
   sxl: tlc
+  type: tlc
   intervals:
     timer: 0.1
     watchdog: 0.1

documentation/classes_and_modules.md

@@ -55,7 +55,7 @@ Proxy has to child classes: SiteProxy and SupervisorProxy.
 A SiteProxy represents a connection from a Supervisor to a remote Site. It provides methods for sending commands and requesting status from the connected site.
 
 ### TrafficLightControllerProxy
-A TrafficLightControllerProxy is a specialized SiteProxy for Traffic Light Controller (TLC) sites. It provides high-level methods for common TLC operations like setting signal plans and fetching current plan status. The supervisor automatically creates TLCProxy instances when TLC sites connect (based on the site configuration having `sxl: 'tlc'`).
+A TrafficLightControllerProxy is a specialized SiteProxy for Traffic Light Controller (TLC) sites. It provides high-level methods for common TLC operations like setting signal plans and fetching current plan status. The supervisor automatically creates TLCProxy instances when TLC sites connect (based on the site configuration having `type: 'tlc'`).
 
 ### SiteProxy
 A connection to a remote Site.

documentation/tlc_proxy.md

@@ -15,17 +15,17 @@ The TLC proxy provides convenient methods that abstract away the low-level RSMP
 
 ## Automatic Detection
 
-When a TLC site connects to a supervisor, the supervisor automatically detects that it's a TLC based on the site configuration (`sxl: 'tlc'`) and creates a `TrafficLightControllerProxy` instead of a generic `SiteProxy`.
+When a TLC site connects to a supervisor, the supervisor automatically detects that it's a TLC based on the site configuration (`type: 'tlc'`) and creates a `TrafficLightControllerProxy` instead of a generic `SiteProxy`.
 
 This happens in the supervisor's connection handling:
 
 ```ruby
 # In supervisor configuration
 supervisor_settings = {
   'sites' => {
-    'TLC001' => { 'sxl' => 'tlc' }
+    'TLC001' => { 'sxl' => 'tlc', 'type' => 'tlc' }
   },
-  'guest' => { 'sxl' => 'tlc' }  # For unknown TLC sites
+  'guest' => { 'sxl' => 'tlc', 'type' => 'tlc' }  # For unknown TLC sites
 }
 
 # When TLC001 connects, supervisor creates TLCProxy automatically

lib/rsmp/supervisor.rb

@@ -23,6 +23,7 @@ def handle_supervisor_settings supervisor_settings
         'ips' => 'all',
         'guest' => {
           'sxl' => 'tlc',
+          'type' => 'tlc',
           'intervals' => {
             'timer' => 1,
             'watchdog' => 1
@@ -178,7 +179,7 @@ def accept_connection socket, info
 
         # Determine the appropriate proxy type based on site settings
         site_settings = check_site_id id
-        if site_settings && site_settings['sxl'] == 'tlc'
+        if site_settings && site_settings['type'] == 'tlc'
           proxy = TLC::TrafficLightControllerProxy.new settings.merge(site_id:id)
         else
           proxy = SiteProxy.new settings.merge(site_id:id)

spec/supervisor_spec.rb

@@ -170,9 +170,9 @@ def connect task, core_versions:, sxl_version:
           supervisor_settings: {
             'port' => 13113,
             'sites' => {
-              'TLC001' => { 'sxl' => 'tlc' }
+              'TLC001' => { 'sxl' => 'tlc', 'type' => 'tlc' }
             },
-            'guest' => { 'sxl' => 'tlc' }
+            'guest' => { 'sxl' => 'tlc', 'type' => 'tlc' }
           },
           log_settings: log_settings
         )
@@ -193,7 +193,7 @@ def connect task, core_versions:, sxl_version:
         }
 
         # Test the logic that would be used in accept_connection
-        if site_settings && site_settings['sxl'] == 'tlc'
+        if site_settings && site_settings['type'] == 'tlc'
           proxy = RSMP::TLC::TrafficLightControllerProxy.new settings.merge(site_id: 'TLC001')
         else
           proxy = RSMP::SiteProxy.new settings.merge(site_id: 'TLC001')
@@ -208,7 +208,7 @@ def connect task, core_versions:, sxl_version:
         # Test the core proxy creation logic directly
         # Create a basic supervisor for the test
         test_supervisor = RSMP::Supervisor.new(
-          supervisor_settings: { 'port' => 13115, 'guest' => { 'sxl' => 'tlc' } },
+          supervisor_settings: { 'port' => 13115, 'guest' => { 'sxl' => 'tlc', 'type' => 'tlc' } },
           log_settings: log_settings
         )
 
@@ -225,18 +225,18 @@ def connect task, core_versions:, sxl_version:
         }
 
         # Test with TLC-like settings
-        tlc_site_settings = { 'sxl' => 'tlc' }
-        non_tlc_site_settings = { 'sxl' => 'core' }
+        tlc_site_settings = { 'sxl' => 'tlc', 'type' => 'tlc' }
+        non_tlc_site_settings = { 'sxl' => 'core', 'type' => 'core' }
 
         # Test TLC proxy creation
-        if tlc_site_settings && tlc_site_settings['sxl'] == 'tlc'
+        if tlc_site_settings && tlc_site_settings['type'] == 'tlc'
           tlc_proxy = RSMP::TLC::TrafficLightControllerProxy.new settings.merge(site_id: 'TLC001')
         else
           tlc_proxy = RSMP::SiteProxy.new settings.merge(site_id: 'TLC001')
         end
 
         # Test non-TLC proxy creation
-        if non_tlc_site_settings && non_tlc_site_settings['sxl'] == 'tlc'
+        if non_tlc_site_settings && non_tlc_site_settings['type'] == 'tlc'
           non_tlc_proxy = RSMP::TLC::TrafficLightControllerProxy.new settings.merge(site_id: 'OTHER001')
         else
           non_tlc_proxy = RSMP::SiteProxy.new settings.merge(site_id: 'OTHER001')
@@ -271,7 +271,7 @@ def connect task, core_versions:, sxl_version:
         }
 
         # Test the logic for non-TLC sites
-        if site_settings && site_settings['sxl'] == 'tlc'
+        if site_settings && site_settings['type'] == 'tlc'
           proxy = RSMP::TLC::TrafficLightControllerProxy.new settings.merge(site_id: 'OTHER001')
         else
           proxy = RSMP::SiteProxy.new settings.merge(site_id: 'OTHER001')

spec/tlc/traffic_light_controller_proxy_integration_spec.rb

@@ -28,10 +28,11 @@
     {
       'port' => port,
       'sites' => {
-        site_id => { 'sxl' => 'tlc' }
+        site_id => { 'sxl' => 'tlc', 'type' => 'tlc' }
       },
       'guest' => {
-        'sxl' => 'tlc'  # Use valid schema type
+        'sxl' => 'tlc',  # Use valid schema type
+        'type' => 'tlc'   # Proxy type
       }
     }
   }
@@ -122,7 +123,7 @@
     AsyncRSpec.async do |task|
       # Create a supervisor with TLC configuration to avoid schema errors
       supervisor_without_connection = RSMP::Supervisor.new(
-        supervisor_settings: { 'port' => 13113, 'guest' => { 'sxl' => 'tlc' } },
+        supervisor_settings: { 'port' => 13113, 'guest' => { 'sxl' => 'tlc', 'type' => 'tlc' } },
         log_settings: log_settings
       )