Skip to content

Commit 57deb6f

Browse files
committed
Fix warnings for slow usage of length/1
1 parent ace6edd commit 57deb6f

2 files changed

Lines changed: 2 additions & 6 deletions

File tree

lib/credo/check/readability/parentheses_on_zero_arity_defs.ex

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ defmodule Credo.Check.Readability.ParenthesesOnZeroArityDefs do
4747
{ast, ctx}
4848
end
4949

50-
defp walk({unquote(op), _, [{_, _, args} | _]} = ast, ctx) when length(args) > 0 do
50+
defp walk({unquote(op), _, [{_, _, [_at_least_one_arg | _rest]} | _]} = ast, ctx) do
5151
{ast, ctx}
5252
end
5353

lib/credo/check/refactor/variable_rebinding.ex

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -75,11 +75,7 @@ defmodule Credo.Check.Refactor.VariableRebinding do
7575
issue_for(ctx, variable_name, line)
7676
end)
7777

78-
if length(new_issues) > 0 do
79-
{ast, put_issue(ctx, new_issues)}
80-
else
81-
{ast, ctx}
82-
end
78+
{ast, put_issue(ctx, new_issues)}
8379
end
8480

8581
defp walk(ast, ctx) do

0 commit comments

Comments
 (0)