Skip to content

Commit ff31ffe

Browse files
replace deprecated encodings 'yuv422' and 'yuv422_yuy2' (#1276)
1 parent 8e757c2 commit ff31ffe

File tree

2 files changed

+14
-14
lines changed

2 files changed

+14
-14
lines changed

rviz_default_plugins/include/rviz_default_plugins/displays/image/ros_image_texture.hpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -128,8 +128,8 @@ class ROSImageTexture : public ROSImageTextureIface
128128
const T * data_ptr, size_t num_elements, T & min_value, T & max_value);
129129
template<typename T>
130130
ImageData convertTo8bit(const uint8_t * data_ptr, size_t data_size_in_bytes);
131-
ImageData convertYUV422ToRGBData(const uint8_t * data_ptr, size_t data_size_in_bytes);
132-
ImageData convertYUV422_YUY2ToRGBData(const uint8_t * data_ptr, size_t data_size_in_bytes);
131+
ImageData convertUYVYToRGBData(const uint8_t * data_ptr, size_t data_size_in_bytes);
132+
ImageData convertYUYVToRGBData(const uint8_t * data_ptr, size_t data_size_in_bytes);
133133

134134
ImageData setFormatAndNormalizeDataIfNecessary(
135135
const std::string & encoding, const uint8_t * data_ptr, size_t data_size_in_bytes);

rviz_default_plugins/src/rviz_default_plugins/displays/image/ros_image_texture.cpp

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -206,8 +206,8 @@ struct uyvy
206206
uint8_t y1;
207207
};
208208

209-
// Function converts src_img from yuv422 format to rgb
210-
static void imageConvertYUV422ToRGB(
209+
// Function converts src_img from UYVY format to rgb
210+
static void imageConvertUYVYToRGB(
211211
uint8_t * dst_img, uint8_t * src_img,
212212
int dst_start_row, int dst_end_row,
213213
int dst_num_cols, uint32_t stride_in_bytes)
@@ -266,8 +266,8 @@ static void imageConvertYUV422ToRGB(
266266
}
267267
}
268268

269-
// Function converts src_img from yuv422_yuy2 format to rgb
270-
static void imageConvertYUV422_YUY2ToRGB(
269+
// Function converts src_img from YUYV format to rgb
270+
static void imageConvertYUYVToRGB(
271271
uint8_t * dst_img, uint8_t * src_img,
272272
int dst_start_row, int dst_end_row,
273273
int dst_num_cols, uint32_t stride_in_bytes)
@@ -411,27 +411,27 @@ ROSImageTexture::convertTo8bit(const uint8_t * data_ptr, size_t data_size_in_byt
411411
}
412412

413413
ImageData
414-
ROSImageTexture::convertYUV422ToRGBData(const uint8_t * data_ptr, size_t data_size_in_bytes)
414+
ROSImageTexture::convertUYVYToRGBData(const uint8_t * data_ptr, size_t data_size_in_bytes)
415415
{
416416
size_t new_size_in_bytes = data_size_in_bytes * 3 / 2;
417417

418418
uint8_t * new_data = new uint8_t[new_size_in_bytes];
419419

420-
imageConvertYUV422ToRGB(
420+
imageConvertUYVYToRGB(
421421
new_data, const_cast<uint8_t *>(data_ptr),
422422
0, height_, width_, stride_);
423423

424424
return ImageData(Ogre::PF_BYTE_RGB, new_data, new_size_in_bytes, true);
425425
}
426426

427427
ImageData
428-
ROSImageTexture::convertYUV422_YUY2ToRGBData(const uint8_t * data_ptr, size_t data_size_in_bytes)
428+
ROSImageTexture::convertYUYVToRGBData(const uint8_t * data_ptr, size_t data_size_in_bytes)
429429
{
430430
size_t new_size_in_bytes = data_size_in_bytes * 3 / 2;
431431

432432
uint8_t * new_data = new uint8_t[new_size_in_bytes];
433433

434-
imageConvertYUV422_YUY2ToRGB(
434+
imageConvertYUYVToRGB(
435435
new_data, const_cast<uint8_t *>(data_ptr),
436436
0, height_, width_, stride_);
437437

@@ -474,10 +474,10 @@ ROSImageTexture::setFormatAndNormalizeDataIfNecessary(
474474
return ImageData(Ogre::PF_BYTE_L, data_ptr, data_size_in_bytes, false);
475475
} else if (encoding == sensor_msgs::image_encodings::TYPE_32FC1) {
476476
return convertTo8bit<float>(data_ptr, data_size_in_bytes);
477-
} else if (encoding == sensor_msgs::image_encodings::YUV422) {
478-
return convertYUV422ToRGBData(data_ptr, data_size_in_bytes);
479-
} else if (encoding == sensor_msgs::image_encodings::YUV422_YUY2) {
480-
return convertYUV422_YUY2ToRGBData(data_ptr, data_size_in_bytes);
477+
} else if (encoding == sensor_msgs::image_encodings::UYVY) {
478+
return convertUYVYToRGBData(data_ptr, data_size_in_bytes);
479+
} else if (encoding == sensor_msgs::image_encodings::YUYV) {
480+
return convertYUYVToRGBData(data_ptr, data_size_in_bytes);
481481
} else {
482482
throw UnsupportedImageEncoding(encoding);
483483
}

0 commit comments

Comments
 (0)