Add fault injection macros and test #509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephen Brawner <[email protected]>
Contributor
Author
|
Builds and tests of the following packages
|
Signed-off-by: Stephen Brawner <[email protected]>
brawner
force-pushed
the
brawner/fault-injection-macros
branch
from
4f17b5b to
43b6e0c
Compare
Contributor
Author
|
Testing this PR branch against current ros2 branches (not fault injection ones). Testing
|
Blast545
approved these changes
Aug 24, 2020
Contributor
Blast545
left a comment
Blast545
left a comment
There was a problem hiding this comment.
LGTM, please check PR job failure before merging
Contributor
Author
|
Similarly to ros2/rcl#727, this PR requires a more up-to-date version of rcutils than the binary release :/ CI jobs I posted above are built with the current ros 2 branches |
ahcorde
pushed a commit
that referenced
this pull request
Oct 2, 2020
* Add fault injection macros and test Signed-off-by: Stephen Brawner <[email protected]> * target definitions Signed-off-by: Stephen Brawner <[email protected]>
ahcorde
pushed a commit
that referenced
this pull request
Oct 7, 2020
* Add fault injection macros and test Signed-off-by: Stephen Brawner <[email protected]> * target definitions Signed-off-by: Stephen Brawner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds fault injection macros and unit tests to rosidl_runtime_c. Coverage should get to 97% or thereabouts. I'll run CI tests shortly.
Signed-off-by: Stephen Brawner [email protected]