Skip to content

Commit 2a66441

Browse files
authored
export missing targets for single typesupport build, avoid exposing build directories in include dirs (#477)
Signed-off-by: Dirk Thomas <[email protected]>
1 parent 4f75c92 commit 2a66441

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

rosidl_typesupport_introspection_c/cmake/rosidl_typesupport_introspection_c_generate_interfaces.cmake

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -105,8 +105,8 @@ if(WIN32)
105105
endif()
106106
target_include_directories(${rosidl_generate_interfaces_TARGET}${_target_suffix}
107107
PUBLIC
108-
${CMAKE_CURRENT_BINARY_DIR}/rosidl_generator_c
109-
${CMAKE_CURRENT_BINARY_DIR}/rosidl_typesupport_introspection_c
108+
"$<BUILD_INTERFACE:${CMAKE_CURRENT_BINARY_DIR}/rosidl_generator_c>"
109+
"$<BUILD_INTERFACE:${CMAKE_CURRENT_BINARY_DIR}/rosidl_typesupport_introspection_c>"
110110
)
111111
target_link_libraries(${rosidl_generate_interfaces_TARGET}${_target_suffix}
112112
${rosidl_generate_interfaces_TARGET}__rosidl_generator_c)
@@ -136,12 +136,14 @@ if(NOT rosidl_generate_interfaces_SKIP_INSTALL)
136136
endif()
137137
install(
138138
TARGETS ${rosidl_generate_interfaces_TARGET}${_target_suffix}
139+
EXPORT ${rosidl_generate_interfaces_TARGET}${_target_suffix}
139140
ARCHIVE DESTINATION lib
140141
LIBRARY DESTINATION lib
141142
RUNTIME DESTINATION bin
142143
)
143144
rosidl_export_typesupport_libraries(${_target_suffix}
144145
${rosidl_generate_interfaces_TARGET}${_target_suffix})
146+
ament_export_targets(${rosidl_generate_interfaces_TARGET}${_target_suffix})
145147
endif()
146148

147149
if(BUILD_TESTING AND rosidl_generate_interfaces_ADD_LINTER_TESTS)

rosidl_typesupport_introspection_cpp/cmake/rosidl_typesupport_introspection_cpp_generate_interfaces.cmake

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ if(CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES "Clang")
9595
endif()
9696
target_include_directories(${rosidl_generate_interfaces_TARGET}${_target_suffix}
9797
PUBLIC
98-
${CMAKE_CURRENT_BINARY_DIR}/rosidl_generator_cpp
98+
"$<BUILD_INTERFACE:${CMAKE_CURRENT_BINARY_DIR}/rosidl_generator_cpp>"
9999
)
100100
ament_target_dependencies(${rosidl_generate_interfaces_TARGET}${_target_suffix}
101101
"rosidl_runtime_c"
@@ -129,12 +129,14 @@ if(NOT rosidl_generate_interfaces_SKIP_INSTALL)
129129
endif()
130130
install(
131131
TARGETS ${rosidl_generate_interfaces_TARGET}${_target_suffix}
132+
EXPORT ${rosidl_generate_interfaces_TARGET}${_target_suffix}
132133
ARCHIVE DESTINATION lib
133134
LIBRARY DESTINATION lib
134135
RUNTIME DESTINATION bin
135136
)
136137
rosidl_export_typesupport_libraries(${_target_suffix}
137138
${rosidl_generate_interfaces_TARGET}${_target_suffix})
139+
ament_export_targets(${rosidl_generate_interfaces_TARGET}${_target_suffix})
138140
endif()
139141

140142
if(BUILD_TESTING AND rosidl_generate_interfaces_ADD_LINTER_TESTS)

0 commit comments

Comments
 (0)