From 732bf5cb409b875d87c296a6ebaf78c62cc6fb7a Mon Sep 17 00:00:00 2001 From: Jacob Perron Date: Mon, 21 Sep 2020 11:48:23 -0700 Subject: [PATCH 1/2] Add note about rclcpp_action API change in Galactic Related PR: https://github.com/ros2/rclcpp/pull/1311 Signed-off-by: Jacob Perron --- .../Releases/Release-Galactic-Geochelone.rst | 22 +++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/source/Releases/Release-Galactic-Geochelone.rst b/source/Releases/Release-Galactic-Geochelone.rst index f1b46a050e0..168406b439f 100644 --- a/source/Releases/Release-Galactic-Geochelone.rst +++ b/source/Releases/Release-Galactic-Geochelone.rst @@ -75,6 +75,28 @@ Change in default ``/clock`` subscription QoS profile The default was changed from a reliable communication with history depth 10 to a best effort communication with history depth 1. See `ros2/rclcpp#1312 `_. +rclcpp_action +^^^^^^^^^^^^^ + +Action client goal response callback signature changed +"""""""""""""""""""""""""""""""""""""""""""""""""""""" + +The goal response callback should now take a shared pointer to a goal handle, instead of a future. + +For `example `_, old signature: + +.. code-block:: c++ + + void goal_response_callback(std::shared_future future) + +New signature: + +.. code-clock:: c++ + + void goal_response_callback(GoalHandleFibonacci::SharedPtr goal_handle) + +Related PR: `ros2/rclcpp#1311 `_ + Known Issues ------------ From a0eafa376baa4fea0b42c2ceb3e8252fc9d9d52e Mon Sep 17 00:00:00 2001 From: Jacob Perron Date: Mon, 21 Sep 2020 11:50:29 -0700 Subject: [PATCH 2/2] Fix typo Signed-off-by: Jacob Perron --- source/Releases/Release-Galactic-Geochelone.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/Releases/Release-Galactic-Geochelone.rst b/source/Releases/Release-Galactic-Geochelone.rst index 168406b439f..43492f46ec2 100644 --- a/source/Releases/Release-Galactic-Geochelone.rst +++ b/source/Releases/Release-Galactic-Geochelone.rst @@ -91,7 +91,7 @@ For `example `_, old signature: New signature: -.. code-clock:: c++ +.. code-block:: c++ void goal_response_callback(GoalHandleFibonacci::SharedPtr goal_handle)