Add Galactic feature note for externally configuring QoS #1033
Conversation
Signed-off-by: Jacob Perron <[email protected]>
|
cc/ @maryaB-osr Once it's ready, we can add a link to the tutorial here too |
| ------------------------------------ | ||
|
|
||
| It is now possible to externally configure the QoS settings for a node at start-up time. | ||
| QoS settings are **not** configurable during runtime and node authors must opt-in to enable this feature. |
There was a problem hiding this comment.
this seems a bit confusing to me, maybe:
| QoS settings are **not** configurable during runtime and node authors must opt-in to enable this feature. | |
| QoS settings are configurable during runtime only if the node authors have enabled this feature. |
There was a problem hiding this comment.
@ivanpauno I think that rewrite completely changes the meaning, and suggests that QoS can be changed via runtime. So I don't think we want to say that.
Really, I think this sentence should be split into two because it is talk about two separate topics. Something like:
QoS settings are **not** configurable during runtime; they are only configurable at start-up time.
In order to change the QoS settings at runtime, node authors must opt-in to enable this feature.
Or something like that. The previous sentence may need to be tweaked as well.
There was a problem hiding this comment.
ah ok, I got it now.
The distinction between "runtime" and "startup time" can be confusing (because "startup time" is also "runtime").
Really, I think this sentence should be split into two because it is talk about two separate topics
👍 your suggested wording looks fine!
Signed-off-by: Jacob Perron <[email protected]>
delete-merged-branch
bot
deleted the
jacob/galactic_feat/configure_qos
branch
|
@Mergifyio backport rolling |
* Add Galactic feature note for externally configuring QoS Signed-off-by: Jacob Perron <[email protected]> (cherry picked from commit 76c31dc)
|
Command
|
* Add Galactic feature note for externally configuring QoS Signed-off-by: Jacob Perron <[email protected]> (cherry picked from commit 76c31dc) Co-authored-by: Jacob Perron <[email protected]>
* Add Galactic feature note for externally configuring QoS Signed-off-by: Jacob Perron <[email protected]> (cherry picked from commit 76c31dc) Co-authored-by: Jacob Perron <[email protected]> (cherry picked from commit 1d457fe)
* Add Galactic feature note for externally configuring QoS Signed-off-by: Jacob Perron <[email protected]> (cherry picked from commit 76c31dc) Co-authored-by: Jacob Perron <[email protected]> (cherry picked from commit 1d457fe)
…) (#1040) * Add Galactic feature note for externally configuring QoS Signed-off-by: Jacob Perron <[email protected]> (cherry picked from commit 76c31dc) Co-authored-by: Jacob Perron <[email protected]> (cherry picked from commit 1d457fe) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
…) (#1041) * Add Galactic feature note for externally configuring QoS Signed-off-by: Jacob Perron <[email protected]> (cherry picked from commit 76c31dc) Co-authored-by: Jacob Perron <[email protected]> (cherry picked from commit 1d457fe) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
wow, I want to use that!! |
|
Command
|
|
we have checked that it handles a duplicated command correctly now hahaha |
Design doc: http://design.ros2.org/articles/qos_configurability.html
Implementation (C++): ros2/rclcpp#1408
Implementation (Python): ros2/rclpy#635