Skip to content

Commit 9bff7f2

Browse files
committed
Address peer review comments.
Signed-off-by: Michel Hidalgo <[email protected]>
1 parent f4a05ec commit 9bff7f2

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

test_rmw_implementation/test/test_init_shutdown.cpp

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,10 +68,12 @@ TEST_F(CLASSNAME(TestInitShutdown, RMW_IMPLEMENTATION), shutdown_with_bad_argume
6868
rcutils_reset_error();
6969

7070
rmw_context_t context = rmw_get_zero_initialized_context();
71-
EXPECT_NE(RMW_RET_OK, rmw_shutdown(&context));
71+
rmw_ret_t ret = rmw_shutdown(&context);
72+
EXPECT_TRUE((RMW_RET_INCORRECT_RMW_IMPLEMENTATION == ret) ||
73+
(RMW_RET_INVALID_ARGUMENT == ret));
7274
rcutils_reset_error();
7375

74-
rmw_ret_t ret = rmw_init(&options, &context);
76+
ret = rmw_init(&options, &context);
7577
ASSERT_EQ(RMW_RET_OK, ret) << rcutils_get_error_string().str;
7678
OSRF_TESTING_TOOLS_CPP_SCOPE_EXIT(
7779
{

0 commit comments

Comments
 (0)