Added feedback

Signed-off-by: ahcorde <[email protected]>

Author: ahcorde

test_rmw_implementation/test/test_client.cpp

@@ -87,9 +87,24 @@ TEST_F(
   EXPECT_EQ(ret, RMW_RET_ERROR) << rmw_get_error_string().str;
   rmw_reset_error();
 
+  ret = rmw_service_server_is_available(node, nullptr, nullptr);
+  EXPECT_EQ(ret, RMW_RET_ERROR) << rmw_get_error_string().str;
+  rmw_reset_error();
+
   ret = rmw_service_server_is_available(node, nullptr, &is_available);
   EXPECT_EQ(ret, RMW_RET_ERROR) << rmw_get_error_string().str;
   rmw_reset_error();
+
+  ret = rmw_service_server_is_available(node, client, nullptr);
+  EXPECT_EQ(ret, RMW_RET_ERROR) << rmw_get_error_string().str;
+  rmw_reset_error();
+
+  const char * implementation_identifier = client->implementation_identifier;
+  client->implementation_identifier = "not-an-rmw-implementation-identifier";
+  ret = rmw_service_server_is_available(node, client, &is_available);
+  client->implementation_identifier = implementation_identifier;
+  EXPECT_EQ(ret, RMW_RET_INCORRECT_RMW_IMPLEMENTATION) << rmw_get_error_string().str;
+  rmw_reset_error();
 }
 
 TEST_F(
@@ -128,26 +143,6 @@ TEST_F(
   EXPECT_EQ(RMW_RET_OK, ret) << rmw_get_error_string().str;
 }
 
-TEST_F(CLASSNAME(TestServiceServerIsAvailable, RMW_IMPLEMENTATION), rmw_client_destroy_bad_args)
-{
-  const rosidl_service_type_support_t * ts =
-    ROSIDL_GET_SRV_TYPE_SUPPORT(test_msgs, srv, BasicTypes);
-  rmw_client_t * client_to_destroy = rmw_create_client(
-    node, ts, "/service_name_test",
-    &rmw_qos_profile_default);
-  rmw_ret_t ret = rmw_destroy_client(nullptr, client_to_destroy);
-  EXPECT_EQ(RMW_RET_INVALID_ARGUMENT, ret) << rmw_get_error_string().str;
-  rmw_reset_error();
-
-  ret = rmw_destroy_client(node, nullptr);
-  EXPECT_EQ(RMW_RET_INVALID_ARGUMENT, ret) << rmw_get_error_string().str;
-  rmw_reset_error();
-
-  ret = rmw_destroy_client(node, client_to_destroy);
-  EXPECT_EQ(RMW_RET_OK, ret) << rmw_get_error_string().str;
-  rmw_reset_error();
-}
-
 TEST_F(CLASSNAME(TestServiceServerIsAvailable, RMW_IMPLEMENTATION), rmw_create_client_fault)
 {
   // Battle test rmw_create_wait_set.