Rename rosidl_message_bounds_t #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clalancette
approved these changes
Apr 24, 2020
Contributor
clalancette
left a comment
clalancette
left a comment
There was a problem hiding this comment.
CI is failing here, but what its failing on doesn't have to do with this PR. It would probably fail anyway, since it wouldn't check out the other repositories with this change. Either way, the code looks OK to me.
Signed-off-by: Michael Carroll <[email protected]>
mjcarroll
force-pushed
the
message_bounds_t
branch
from
c0ad34d to
9d1e19d
Compare
Signed-off-by: Michael Carroll <[email protected]>
Contributor
|
Approved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses changes from ros2/rosidl#475
Signed-off-by: Michael Carroll [email protected]