Skip to content

Conversation

@mikaelarguedas
Copy link
Member

Signed-off-by: Mikael Arguedas [email protected]

@mikaelarguedas
Copy link
Member Author

CI at ros2/sros2#198 (comment)

@mikaelarguedas mikaelarguedas marked this pull request as ready for review April 10, 2020 12:57
@ivanpauno
Copy link
Member

You can ignore the failing checks, as they don't take in account simultaneous in other repos.
About the Dashing check, it seems to be failing because of unrelated reasons.

Signed-off-by: Mikael Arguedas <[email protected]>
Signed-off-by: Mikael Arguedas <[email protected]>
Copy link
Collaborator

@rotu rotu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending ros2/rmw#211

The dashing check can be ignored - it shouldn't be running on this commit, which doesn't target dashing. The other failures look like they'll pass once ros2/rmw#211 is merged.

@ivanpauno ivanpauno merged commit 0450e2d into ros2:master Apr 13, 2020
@mikaelarguedas mikaelarguedas deleted the enclaves branch April 13, 2020 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants