Skip to content

Commit c63c657

Browse files
committed
For CI, always build ROS from source
Binary builds build silently on non-Linux platforms, so we previously weren't *actually* testing Eloquent and Dashing on Windows.
1 parent 95cee7d commit c63c657

File tree

1 file changed

+17
-8
lines changed

1 file changed

+17
-8
lines changed

.github/workflows/CI.yml

Lines changed: 17 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,18 +3,27 @@ on: [push, pull_request]
33
jobs:
44
build:
55
strategy:
6+
fail-fast: false
67
matrix:
78
os: [ubuntu-18.04, macOS-latest, windows-latest]
8-
rosdistro: [dashing, eloquent, source]
9-
exclude: # issue in [email protected]
10-
- os: ubuntu-18.04
11-
rosdistro: source
9+
repos-url:
10+
- https://raw.githubusercontent.com/ros2/ros2/dashing/ros2.repos
11+
- https://raw.githubusercontent.com/ros2/ros2/eloquent/ros2.repos
12+
- https://raw.githubusercontent.com/ros2/ros2/master/ros2.repos
13+
exclude:
14+
# pending https://github.com/ament/ament_cmake/pull/233
15+
- os: windows-latest
16+
repos-url: https://raw.githubusercontent.com/ros2/ros2/eloquent/ros2.repos
17+
# pending https://github.com/ament/ament_cmake/pull/234
18+
- os: windows-latest
19+
repos-url: https://raw.githubusercontent.com/ros2/ros2/dashing/ros2.repos
1220
runs-on: ${{ matrix.os }}
1321
steps:
14-
- uses: ros-tooling/[email protected]
15-
with:
16-
required-ros-distributions: ${{ matrix.rosdistro }}
17-
- uses: ros-tooling/[email protected]
22+
- name: Acquire ROS dependencies
23+
uses: ros-tooling/[email protected]
24+
- name: Build and test ROS
25+
uses: ros-tooling/[email protected]
1826
with:
1927
package-name: rmw_cyclonedds_cpp
28+
vcs-repo-file-url: ${{ matrix.repos-url }}
2029

0 commit comments

Comments
 (0)