Expose qos setting for /rosout #253
Conversation
Signed-off-by: Ada-King <[email protected]>
Ada-King
force-pushed
the
topic-expose-qos-setting
branch
from
e457d98 to
0bf952b
Compare
| false | ||
| }; | ||
|
|
||
| static const rmw_qos_profile_t rmw_rosout_qos_profile_default = |
There was a problem hiding this comment.
| static const rmw_qos_profile_t rmw_rosout_qos_profile_default = | |
| static const rmw_qos_profile_t rmw_qos_profile_rosout_default = |
There was a problem hiding this comment.
Is this expected to be used for ros2cli profile such as ros2 topic echo --qos-profile rosout_default /rosout?
There was a problem hiding this comment.
I don't familiar with the roscli code, but i think it can be used after expanding the code about parsing user input.
I will check it later.
| #define RMW_QOS_LIFESPAN_DEFAULT {0, 0} | ||
|
|
||
| /// Rosout QoS Lifespan default, 10s indicate lifespan policies are tracked | ||
| #define RMW_ROSOUT_QOS_LIFESPAN_DEFAULT {10, 0} |
There was a problem hiding this comment.
I am not so convinced that we introduce specific default value only for rosout. instead of this, could we just specify {10, 0}?
There was a problem hiding this comment.
Yes, i think it make more sense, i will modity it.
ivanpauno
left a comment
ivanpauno
left a comment
There was a problem hiding this comment.
I don't see the value of defining the default rosout topic qos here
The definition of default rosout qos profile has been moved to rcl layer, so i will close this PR. And the 722 needs you to re-check. |
3 participants
Related issue 581
Signed-off-by: Ada-King [email protected]