From 21a1d460b569778c9036247c3459164638eead8a Mon Sep 17 00:00:00 2001 From: Audrow Nash Date: Tue, 13 Oct 2020 14:36:27 -0700 Subject: [PATCH 1/2] Add warnings Signed-off-by: Audrow Nash --- rcl_yaml_param_parser/CMakeLists.txt | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/rcl_yaml_param_parser/CMakeLists.txt b/rcl_yaml_param_parser/CMakeLists.txt index 218801b5c..397f662ae 100644 --- a/rcl_yaml_param_parser/CMakeLists.txt +++ b/rcl_yaml_param_parser/CMakeLists.txt @@ -13,7 +13,10 @@ if(NOT CMAKE_CXX_STANDARD) endif() if(CMAKE_COMPILER_IS_GNUCC OR CMAKE_C_COMPILER_ID MATCHES "Clang") - add_compile_options(-Wall -Wextra -Wpedantic) + add_compile_options( + -Wall -Wextra -Wpedantic + -Wformat=2 -Wconversion -Wsign-conversion + ) endif() set(rcl_yaml_parser_sources From 0e3978c57ae7bf1fcec88e534f4fa9aaf35c1cfb Mon Sep 17 00:00:00 2001 From: Audrow Nash Date: Thu, 3 Dec 2020 12:01:03 -0800 Subject: [PATCH 2/2] Fix conversion warning by casting to size_t Signed-off-by: Audrow Nash --- rcl_yaml_param_parser/src/parse.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rcl_yaml_param_parser/src/parse.c b/rcl_yaml_param_parser/src/parse.c index c7cd69c7f..acce68a92 100644 --- a/rcl_yaml_param_parser/src/parse.c +++ b/rcl_yaml_param_parser/src/parse.c @@ -501,7 +501,7 @@ _validate_name(const char * name, rcutils_allocator_t allocator) } } else { // substring namespace including the last '/' - char * namespace_ = rcutils_strndup(name, separator_pos - name + 1, allocator); + char * namespace_ = rcutils_strndup(name, ((size_t) (separator_pos - name)) + 1, allocator); if (NULL == namespace_) { ret = RCUTILS_RET_BAD_ALLOC; goto clean; @@ -534,7 +534,7 @@ _validate_name(const char * name, rcutils_allocator_t allocator) } } else { do { - size_t len = separator_pos - absolute_namespace - i; + size_t len = ((size_t) (separator_pos - absolute_namespace)) - i; char * namespace_ = rcutils_strndup(absolute_namespace + i, len, allocator); if (NULL == namespace_) { ret = RCUTILS_RET_BAD_ALLOC;