[Backport Foxy] Increased RCL coverage #826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>
* Add bad argument tests for subscription.c * Add missing rcl_reset_error() * Add test failing cyclone * Disable test not working for rmw_cyclone_cpp * Add simple bad alloc test * Add tests enclave_name * Revert "Add tests enclave_name" * Move init/fini tests * Add auxiliar testing class * Reformat into smaller tests * Add checks ini/fini rmw messages * Add issue report for disabled test * Add assert for msg init * Add bad_allocator test Signed-off-by: Jorge Perez <[email protected]>
* Remove unused check context.c * Add test for functionality removed * Add rcl_reset_error() statement Signed-off-by: Jorge Perez <[email protected]>
* Improve rcl init test coverage. Signed-off-by: Michel Hidalgo <[email protected]> * Address peer review comments. Signed-off-by: Michel Hidalgo <[email protected]>
Contributor
Author
|
Compiling up-to
|
Contributor
|
Rebuilding windows. That failure doesn't seem related |
Contributor
Author
|
Rebuilding Windows |
Contributor
Author
|
@brawner CI is green! |
brawner
approved these changes
Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increased RCL coverage.