[foxy] Set domain id to 0 if it is RMW_DEFAULT_DOMAIN_ID #719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
ivanpauno
added
bug
Member
Author
|
@ros-pull-request-builder retest this please |
Member
Author
|
@jacobperron the failure in the PR checker seem to be unrelated, have you seen that failure in the past? |
wjwwood
approved these changes
Jul 17, 2020
wjwwood
approved these changes
Jul 17, 2020
Member
The |
Member
|
@ros-pull-request-builder retest this please |
jacobperron
approved these changes
Jul 18, 2020
Member
jacobperron
left a comment
jacobperron
left a comment
There was a problem hiding this comment.
Looks like those tests are flaky.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #694 (comment).
Backportable alternative to #718.