Skip to content

Commit b6977cc

Browse files
authored
Enable TestInfoByTopicFixture unit tests for other rmw_implementations (#583)
Signed-off-by: Miaofei <[email protected]>
1 parent 25f39c3 commit b6977cc

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

rcl/test/rcl/test_info_by_topic.cpp

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -50,12 +50,9 @@ class CLASSNAME (TestInfoByTopicFixture, RMW_IMPLEMENTATION) : public ::testing:
5050
const char * test_graph_node_name = "test_graph_node";
5151
rmw_topic_endpoint_info_array_t topic_endpoint_info_array;
5252
const char * const topic_name = "valid_topic_name";
53-
bool is_fastrtps, is_cyclonedds;
5453

5554
void SetUp()
5655
{
57-
is_fastrtps = (std::string(rmw_get_implementation_identifier()).find("rmw_fastrtps") == 0);
58-
is_cyclonedds = (std::string(rmw_get_implementation_identifier()).find("rmw_cyclonedds") == 0);
5956
rcl_ret_t ret;
6057
rcl_init_options_t init_options = rcl_get_zero_initialized_init_options();
6158
ret = rcl_init_options_init(&init_options, rcl_get_default_allocator());
@@ -324,10 +321,6 @@ TEST_F(
324321
CLASSNAME(TestInfoByTopicFixture, RMW_IMPLEMENTATION),
325322
test_rcl_get_publishers_subscription_info_by_topic)
326323
{
327-
// This is implemented only in fastrtps and cyclone currently.
328-
if (!is_fastrtps && !is_cyclonedds) {
329-
GTEST_SKIP();
330-
}
331324
rmw_qos_profile_t default_qos_profile = rmw_qos_profile_system_default;
332325
default_qos_profile.history = RMW_QOS_POLICY_HISTORY_KEEP_LAST;
333326
default_qos_profile.depth = 0;

0 commit comments

Comments
 (0)