Skip to content

Commit 633c226

Browse files
committed
Adding TODOs for function reuse
1 parent 6a14a52 commit 633c226

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

rcl/src/rcl/node.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -136,8 +136,11 @@ const char * rcl_get_secure_root(
136136
char * node_fqn = NULL;
137137
char * node_root_path = NULL;
138138
// Combine node namespace with node name
139+
// TODO: This make assumption on the length of the root namespace as well as its value.
140+
// We should likely come from another (rcl/rmw?) function for reuse.
139141
node_fqn = rcutils_format_string(*allocator, "%s%s%s", node_namespace, "/", node_name);
140142
// Get native path, ignore the leading forward slash.
143+
// TODO: The offset should be a define we can access, instead of hardcoding + 1
141144
node_root_path = rcutils_to_native_path(node_fqn + 1, *allocator);
142145
node_secure_root = rcutils_join_path(ros_secure_root_env, node_root_path, *allocator);
143146
allocator->deallocate(node_fqn, allocator->state);

0 commit comments

Comments
 (0)