Refactor to use generic pub/sub from rclcpp #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rebecca Butler <[email protected]>
Contributor
Author
|
Paging @ivanpauno for review. |
ivanpauno
reviewed
Jun 16, 2021
Member
ivanpauno
left a comment
ivanpauno
left a comment
There was a problem hiding this comment.
Good work @rebecca-butler !!
I've left some minor comments.
Merged
Signed-off-by: Rebecca Butler <[email protected]>
ivanpauno
approved these changes
Jun 17, 2021
Member
ivanpauno
left a comment
ivanpauno
left a comment
There was a problem hiding this comment.
LGTM!
I don't have write access, so waiting for @jacobperron to merge it.
P.S.: Maybe we can be given write access here (?)
Member
|
@clalancette Can you give the ROS 2 team write access to this repo? thanks! |
jacobperron
approved these changes
Jun 17, 2021
This was referenced Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #28