all: remove Message interface #67
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chiphamskymavis
force-pushed
the
add-message-struct
branch
from
3740de6 to
a02a250
Compare
chiphamskymavis
force-pushed
the
add-message-struct
branch
3 times, most recently
from
9242b33 to
69ee821
Compare
trantienduchn
approved these changes
Apr 28, 2025
trantienduchn
approved these changes
Apr 28, 2025
sonhv0212
approved these changes
May 27, 2025
chiphamskymavis
force-pushed
the
add-message-struct
branch
from
aec483a to
2bdd3b1
Compare
chiphamskymavis
requested review from
hao-phamSM,
phuctd95,
sm-nam and
tudoanm
as code owners
Contributor
|
close, sum PR has been merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pickup from the original PR: ethereum/go-ethereum#25977
The goal of which is to encapsulate all the Message related structures & abstractions within a single package (core).
But with minimal changes in our codebase.
We still keep NewMessage constructor, which helps us encapsulate the logic for the Sponsor transaction.