Skip to content

Commit 3a2330f

Browse files
authored
Merge pull request #460 from rollbar/added/python3.12
Added support for Python3.12
2 parents 46fb38d + 01231cc commit 3a2330f

File tree

8 files changed

+12
-7
lines changed

8 files changed

+12
-7
lines changed

.github/workflows/ci.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ jobs:
1212
runs-on: ubuntu-20.04
1313
strategy:
1414
matrix:
15-
python-version: [3.6, 3.7, 3.8, 3.9, '3.10', 3.11]
15+
python-version: [3.6, 3.7, 3.8, 3.9, '3.10', 3.11, 3.12]
1616
framework:
1717
- NONE
1818
- FLASK_VERSION=1.1.4
@@ -45,6 +45,8 @@ jobs:
4545
# Django
4646
- framework: DJANGO_VERSION=3.2.25
4747
python-version: 3.11
48+
- framework: DJANGO_VERSION=3.2.25
49+
python-version: 3.12
4850
- framework: DJANGO_VERSION=4.2.15
4951
python-version: 3.6
5052
- framework: DJANGO_VERSION=4.2.15
@@ -61,6 +63,8 @@ jobs:
6163
# Twisted
6264
- framework: TWISTED_VERSION=20.3.0
6365
python-version: 3.11
66+
- framework: TWISTED_VERSION=20.3.0
67+
python-version: 3.12
6468
- framework: TWISTED_VERSION=22.10.0
6569
python-version: 3.6
6670

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ Python notifier for reporting exceptions, errors, and log messages to [Rollbar](
2424

2525
| PyRollbar Version | Python Version Compatibility | Support Level |
2626
|-------------------|-----------------------------------------------|---------------------|
27-
| 1.0.0 | 3.6, 3.7. 3.8, 3.9, 3.10, 3.11 | Full |
27+
| 1.0.0 | 3.6, 3.7. 3.8, 3.9, 3.10, 3.11, 3.12 | Full |
2828
| 0.16.3 | 2.7, 3.4, 3.5, 3.6, 3.7. 3.8, 3.9, 3.10, 3.11 | Security Fixes Only |
2929

3030
#### Support Level Definitions

pyproject.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ classifiers = [
1414
"Programming Language :: Python :: 3.9",
1515
"Programming Language :: Python :: 3.10",
1616
"Programming Language :: Python :: 3.11",
17+
"Programming Language :: Python :: 3.12",
1718
"Programming Language :: Python :: 3 :: Only",
1819
"License :: OSI Approved :: MIT License",
1920
"Operating System :: OS Independent",

rollbar/test/fastapi_tests/test_logger.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ async def read_root():
9999
store_current_request.assert_called_once()
100100

101101
scope = store_current_request.call_args[0][0]
102-
self.assertDictContainsSubset(expected_scope, scope)
102+
self.assertEqual(scope, {**expected_scope, **scope})
103103

104104
def test_should_return_current_request(self):
105105
from fastapi import FastAPI

rollbar/test/fastapi_tests/test_middleware.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -302,7 +302,7 @@ async def read_root():
302302
store_current_request.assert_called_once()
303303

304304
scope = store_current_request.call_args[0][0]
305-
self.assertDictContainsSubset(expected_scope, scope)
305+
self.assertEqual(scope, {**expected_scope, **scope})
306306

307307
@unittest.skipUnless(
308308
sys.version_info >= (3, 6), 'Global request access is supported in Python 3.6+'

rollbar/test/fastapi_tests/test_routing.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -728,7 +728,7 @@ async def read_root():
728728
store_current_request.assert_called_once()
729729

730730
scope = store_current_request.call_args[0][0]
731-
self.assertDictContainsSubset(expected_scope, scope)
731+
self.assertEqual(scope, {**expected_scope, **scope})
732732

733733
@unittest.skipUnless(
734734
sys.version_info >= (3, 6), 'Global request access is supported in Python 3.6+'

rollbar/test/starlette_tests/test_logger.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ async def root(request):
9696
store_current_request.assert_called_once()
9797

9898
scope = store_current_request.call_args[0][0]
99-
self.assertDictContainsSubset(expected_scope, scope)
99+
self.assertEqual(scope, {**expected_scope, **scope})
100100

101101
def test_should_return_current_request(self):
102102
from starlette.applications import Starlette

rollbar/test/starlette_tests/test_middleware.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -273,7 +273,7 @@ async def root(request):
273273
store_current_request.assert_called_once()
274274

275275
scope = store_current_request.call_args[0][0]
276-
self.assertDictContainsSubset(expected_scope, scope)
276+
self.assertEqual(scope, {**expected_scope, **scope})
277277

278278
@unittest.skipUnless(
279279
sys.version_info >= (3, 6), 'Global request access is supported in Python 3.6+'

0 commit comments

Comments
 (0)