Conversation
myitcv
force-pushed
the
cmd_testscript_update
branch
4 times, most recently
from
45ea8d3 to
2e06fa4
Compare
rogpeppe
requested changes
Jan 18, 2021
Owner
rogpeppe
left a comment
rogpeppe
left a comment
There was a problem hiding this comment.
Thanks for doing this! AFAICS there are still a couple of issues the need fixing (or at least test cases adding for them if my assessment is flawed)...
myitcv
force-pushed
the
cmd_testscript_update
branch
2 times, most recently
from
4e70325 to
47e2b36
Compare
Collaborator
Author
|
Thanks for the review, @rogpeppe. All comments addressed, with one small question by way of reply. |
rogpeppe
approved these changes
Jan 19, 2021
Owner
rogpeppe
left a comment
rogpeppe
left a comment
There was a problem hiding this comment.
LGTM with one last thing to do (wouldn't it be nice to have only one copy of the help text?), thanks!
This is exactly equivalent to setting testscript.Params.UpdateScripts
myitcv
force-pushed
the
cmd_testscript_update
branch
from
47e2b36 to
4408f18
Compare
This was referenced Mar 14, 2021
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.