Fix video stream demo image scaling, shaking and color shift#40
Merged
nunoguedelha merged 5 commits intoApr 14, 2022
Merged
Conversation
- The image was trembling due to the display of the HTML element 'write-time'. This element is the image frame refresh interval oscillating between ~9 and ~11 ms, which results in a element length toggling. - As the image has a display 'inline-block' style, it flickers along with the 'write-time' length. - We just use a line break to avoid this effect.
Refer to issue 41. - OpenCV library assumes the color channel order to be BGR or BGRA. - before calling `cv::imencode()`, use `cv::cvtColor()` for converting the original channel order into BGR or BGRA. - an exception is raised for non supported pixel codes.
Collaborator
Author
Collaborator
Author
|
I'm still finishing an approach based on @S-Dafarra's suggestion, but it's already worth reviewing the implementation so far already discussed in the call. |
traversaro
approved these changes
Apr 14, 2022
Member
traversaro
left a comment
traversaro
left a comment
There was a problem hiding this comment.
Thanks, seems ok. Not sure if you want to check if we can do just with YARP but anyhow we can always merge this and improve it later.
Collaborator
Author
Thanks @traversaro , I will submit a separate PR for the improvement, as you suggested, that way it shall be easier to discuss around it and eventually discard it. |
nunoguedelha
deleted the
fix/videoStreamDemo-image-scaling-shaking-colorShift
branch
This was referenced Apr 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39 .