Feat/inference slicer segmentation#1178
Merged
Conversation
SkalskiP
requested changes
May 13, 2024
|
|
||
| def move_detections(detections: Detections, offset: np.array) -> Detections: | ||
| def move_detections( | ||
| detections: Detections, offset: np.ndarray, image_shape: np.ndarray |
Collaborator
There was a problem hiding this comment.
Argument image_shape is called resolution_wh in most places in supervision. Let's keep it this way.
Collaborator
There was a problem hiding this comment.
Also, I think it should be Optional.
Collaborator
|
Also please add |
SkalskiP
requested changes
May 13, 2024
supervision/detection/utils.py
Outdated
| def move_masks( | ||
| masks: np.ndarray, | ||
| offset: np.ndarray, | ||
| desired_shape: Optional[Union[Tuple[int, int, int], Tuple[int, int]]] = None, |
Collaborator
There was a problem hiding this comment.
Why not just resolution_wh?
Contributor
Author
There was a problem hiding this comment.
Yeah, sounds good, will change it
SkalskiP
reviewed
May 13, 2024
SkalskiP
approved these changes
May 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prerequisites:
This allows the slicer to merge segmentation masks.
Previously it would fail when attempting to stack slices of different sizes, as there'd be no attempts to move & pad the slices. The result is that each mask would be of size(slice), rather than size(image).
Type of change
Please delete options that are not relevant.
How has this change been tested, please provide a testcase or example of how you tested the change?
Same notebook as for prior PR.
📓 Google Colab
Any specific deployment considerations
NONE.Docs