Skip to content

Commit ddf0c5e

Browse files
cschindlbeckrobbiefish
authored andcommitted
Added .pre-commit-config.yaml and codespell_word, including github actions CI, fixed spellchecks accordingly (ros-navigation#581)
Signed-off-by: Chris Schindlbeck <[email protected]> Signed-off-by: Rob Fisher <[email protected]>
1 parent 50de002 commit ddf0c5e

File tree

53 files changed

+245
-202
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

53 files changed

+245
-202
lines changed

.codespell_words

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
Configurating
2+
Segway
3+
implementors
4+
retuned
5+
segway

.github/workflows/precommit.yaml

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
---
2+
name: pre-commit
3+
4+
on:
5+
pull_request:
6+
push:
7+
branches: [main]
8+
9+
jobs:
10+
pre-commit:
11+
runs-on: ubuntu-latest
12+
steps:
13+
- uses: actions/checkout@v3
14+
- uses: actions/setup-python@v3
15+
- uses: pre-commit/[email protected]

.pre-commit-config.yaml

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
# To use:
2+
#
3+
# pre-commit run -a
4+
#
5+
# Or:
6+
#
7+
# pre-commit install # (runs every time you commit in git)
8+
#
9+
# To update this file:
10+
#
11+
# pre-commit autoupdate
12+
#
13+
# See https://github.com/pre-commit/pre-commit
14+
---
15+
repos:
16+
# Spellcheck in comments and docs
17+
# skipping of *.svg files is not working...
18+
- repo: https://github.com/codespell-project/codespell
19+
rev: v2.3.0
20+
hooks:
21+
- id: codespell
22+
args: ['--write-changes', '--ignore-words=.codespell_words']
23+
exclude: CHANGELOG\.rst|\.(svg|pyc|drawio|dcf|eds)$

2021summerOfCode/projects/create_configuration_assistant.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
**Task description**
99

10-
`Moveit <https://moveit.ros.org/>`_ has long has a QT `configuration assistant <http://docs.ros.org/kinetic/api/moveit_tutorials/html/doc/setup_assistant/setup_assistant_tutorial.html>`_. This setup assistent helps the user configure their UDRF and needs to setup MoveIt configuration files.
10+
`Moveit <https://moveit.ros.org/>`_ has long has a QT `configuration assistant <http://docs.ros.org/kinetic/api/moveit_tutorials/html/doc/setup_assistant/setup_assistant_tutorial.html>`_. This setup assistant helps the user configure their UDRF and needs to setup MoveIt configuration files.
1111

1212
A configuration assistant could be extremely beneficial to Navigation2 users as a way to minimize friction. We should provide a gui tool to cover the following configurations:
1313

2021summerOfCode/projects/multithreading.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ Some examples include:
1212
- AMCL particle cloud updates
1313
- Costmap layer updates
1414
- Costmap sensor data population
15-
- Controller critic evalulation
15+
- Controller critic evaluation
1616
- Collision checking
1717
- Voxel grid ray casting
1818
- and more.

2021summerOfCode/projects/semantics.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ After creating the generic representation, your project will be to create demons
1818

1919
**Project output requirements**
2020
- Generic semantics standard added to Nav2 documentation
21-
- Generic semantics ROS 2 library that implements the standard and makes it easy for applications to get, retreive, or analyze semantic data for custom purposes
21+
- Generic semantics ROS 2 library that implements the standard and makes it easy for applications to get, retrieve, or analyze semantic data for custom purposes
2222
- A route server to enable navigation-graph and/or route following capabilities
2323
- 1 more demonstration using the semantics library of your choice (could be costmap layer with different rules in different rooms or with different objects, a multi-story building demo using semantic info to allow a robot to plan and execute multi-story trajectories, etc)
2424

2021summerOfCode/projects/spinners.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ This project is admittedly abstract to explain to someone unfamiliar with the in
1111

1212
ROS 2 architecturally was changed before Foxy in order to ensure that any single process containing multiple ROS 2 node objects will share the same DDS participant on the network. This is important due to the overhead that each additional DDS participant has on the system.
1313

14-
In order for nav2 to leverage this the best, we need to adjust our usage of ROS 2 nodes and executors to further minimize the number of node objects in existance. In the early days of ROS 2 when Nav2 was being built, we were required to have many nodes in a single server in order to handle action requests and other callbacks. Now, we can make use of multi-threaded spinners, callback groups, and individual executors for specific tasks.
14+
In order for nav2 to leverage this the best, we need to adjust our usage of ROS 2 nodes and executors to further minimize the number of node objects in existence. In the early days of ROS 2 when Nav2 was being built, we were required to have many nodes in a single server in order to handle action requests and other callbacks. Now, we can make use of multi-threaded spinners, callback groups, and individual executors for specific tasks.
1515

1616
This project will involve identifying all of the Node objects in the stack (control+F makes this easy) and work with mentors to ensure by the end of the summer each server contains only a single node. Additionally, the behavior tree plugins should be updated to leverage callback groups to ensure that any single BT node spinning to check if any new messages are on its callback will **only** trigger its own callback by the same mechanisms.
1717

configuration/packages/bt-plugins/actions/AssistedTeleop.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ Input Ports
3333
====== =======
3434

3535
Description
36-
Time to envoke behavior for, if exceeds considers it a stuck condition or failure case (seconds).
36+
Time to invoke behavior for, if exceeds considers it a stuck condition or failure case (seconds).
3737

3838
:server_name:
3939

configuration/packages/bt-plugins/actions/BackUp.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ Input Ports
4343
====== =======
4444

4545
Description
46-
Time to envoke behavior for, if exceeds considers it a stuck condition or failure case (seconds).
46+
Time to invoke behavior for, if exceeds considers it a stuck condition or failure case (seconds).
4747

4848
:server_name:
4949

configuration/packages/bt-plugins/actions/DriveOnHeading.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ Input Ports
4242
====== =======
4343

4444
Description
45-
Time to envoke behavior for, if exceeds considers it a stuck condition or failure case (seconds).
45+
Time to invoke behavior for, if exceeds considers it a stuck condition or failure case (seconds).
4646

4747
:server_name:
4848

0 commit comments

Comments
 (0)