Skip to content

Commit fc9ca2f

Browse files
authored
Remove redundant self at line 79, 82, 89 from spiders.py (#218)
In spiders.py, got three redundant words "self" in line 79, 82, 89 separately. Cause an error AttributeError: 'MySpider' object has no attribute 'settings'.
1 parent 5f50089 commit fc9ca2f

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/scrapy_redis/spiders.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -76,17 +76,17 @@ def setup_redis(self, crawler=None):
7676

7777
self.server = connection.from_settings(crawler.settings)
7878

79-
if self.settings.getbool('REDIS_START_URLS_AS_SET', defaults.START_URLS_AS_SET):
79+
if settings.getbool('REDIS_START_URLS_AS_SET', defaults.START_URLS_AS_SET):
8080
self.fetch_data = self.server.spop
8181
self.count_size = self.server.scard
82-
elif self.settings.getbool('REDIS_START_URLS_AS_ZSET', defaults.START_URLS_AS_ZSET):
82+
elif settings.getbool('REDIS_START_URLS_AS_ZSET', defaults.START_URLS_AS_ZSET):
8383
self.fetch_data = self.pop_priority_queue
8484
self.count_size = self.server.zcard
8585
else:
8686
self.fetch_data = self.pop_list_queue
8787
self.count_size = self.server.llen
8888

89-
self.max_idle_time = self.settings.getint("MAX_IDLE_TIME_BEFORE_CLOSE")
89+
self.max_idle_time = settings.getint("MAX_IDLE_TIME_BEFORE_CLOSE")
9090

9191
# The idle signal is called when the spider has no requests left,
9292
# that's when we will schedule new requests from redis queue

0 commit comments

Comments
 (0)