remove MutableOpsBufferSupportedLhs and use unsafe mutable_buffer function
#2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Oct 24, 2025
| )] | ||
| pub fn mutable_bitwise_bin_op_helper<F>( | ||
| left: &mut impl MutableOpsBufferSupportedLhs, | ||
| left: &mut MutableBuffer, |
Author
There was a problem hiding this comment.
Rather than hiding what is going on with pub/hidden traits, I think it is clearer to simply pass in the MutableBuffer here
If you accept this PR and #1 we can avoid the #allow about private bounds as well
| /// The caller must ensure that any modifications to the buffer maintain the invariant | ||
| /// `self.len < buffer.len() / 8` (that is that the buffer has enough capacity to hold `self.len` bits). | ||
| #[inline] | ||
| pub unsafe fn mutable_buffer(&mut self) -> &mut MutableBuffer { |
Author
There was a problem hiding this comment.
I personally think the code is much clearer and easier to understand if make a function that directly exposes the inner MutableBuffer (which is what the trait does) but mark it as unsafe, rather than relying on non public traits
This was referenced Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposed simplification for the following PR (merging this PR will update that one):
apply_unary_opandapply_binary_opbitwise operations apache/arrow-rs#8619I will comment inline about the rationale