iface: add callbacks for low-level configuration

Extend iface_type with optional callbacks for setting MAC addresses,
MTU, up/down state, promiscuous mode, allmulticast mode, and VLAN
filtering. This allows interface types to implement hardware-specific
configuration while falling back to generic behavior when callbacks are
not provided.

Implement wrapper functions that validate the interface, check if the
callback is available, and invoke it. For operations that cannot be
performed without hardware support (like promiscuous mode), return
EOPNOTSUPP if the callback is missing and the operation is requested.

Signed-off-by: Robin Jarry <rjarry@redhat.com>

Author: rjarry

modules/infra/control/gr_iface.h

@@ -36,8 +36,15 @@ struct iface_type {
 	);
 	int (*fini)(struct iface *);
 	int (*get_eth_addr)(const struct iface *, struct rte_ether_addr *);
+	int (*set_eth_addr)(struct iface *, const struct rte_ether_addr *);
 	int (*add_eth_addr)(struct iface *, const struct rte_ether_addr *);
 	int (*del_eth_addr)(struct iface *, const struct rte_ether_addr *);
+	int (*set_up_down)(struct iface *, bool up);
+	int (*set_mtu)(struct iface *, uint16_t mtu);
+	int (*set_promisc)(struct iface *, bool enabled);
+	int (*set_allmulti)(struct iface *, bool enabled);
+	int (*add_vlan)(struct iface *, uint16_t vlan_id);
+	int (*del_vlan)(struct iface *, uint16_t vlan_id);
 	void (*to_api)(void *api_info, const struct iface *);
 	const char *name;
 	STAILQ_ENTRY(iface_type) next;
@@ -57,8 +64,15 @@ struct iface *iface_from_id(uint16_t ifid);
 void iface_add_subinterface(struct iface *parent, struct iface *sub);
 void iface_del_subinterface(struct iface *parent, struct iface *sub);
 int iface_get_eth_addr(uint16_t ifid, struct rte_ether_addr *);
+int iface_set_eth_addr(uint16_t ifid, const struct rte_ether_addr *);
 int iface_add_eth_addr(uint16_t ifid, const struct rte_ether_addr *);
 int iface_del_eth_addr(uint16_t ifid, const struct rte_ether_addr *);
+int iface_set_mtu(uint16_t ifid, uint16_t mtu);
+int iface_set_up_down(uint16_t ifid, bool up);
+int iface_set_promisc(uint16_t ifid, bool enabled);
+int iface_set_allmulti(uint16_t ifid, bool enabled);
+int iface_add_vlan(uint16_t ifid, uint16_t vlan_id);
+int iface_del_vlan(uint16_t ifid, uint16_t vlan_id);
 uint16_t ifaces_count(gr_iface_type_t type_id);
 struct iface *iface_next(gr_iface_type_t type_id, const struct iface *prev);
 

modules/infra/control/iface.c

@@ -1,6 +1,7 @@
 // SPDX-License-Identifier: BSD-3-Clause
 // Copyright (c) 2024 Robin Jarry
 
+#include <gr_config.h>
 #include <gr_event.h>
 #include <gr_iface.h>
 #include <gr_log.h>
@@ -257,6 +258,21 @@ void iface_del_subinterface(struct iface *parent, struct iface *sub) {
 	}
 }
 
+int iface_set_eth_addr(uint16_t ifid, const struct rte_ether_addr *mac) {
+	struct iface *iface = iface_from_id(ifid);
+	const struct iface_type *type;
+
+	if (iface == NULL)
+		return -errno;
+
+	type = iface_type_get(iface->type);
+	assert(type != NULL);
+	if (type->set_eth_addr == NULL)
+		return errno_set(EOPNOTSUPP);
+
+	return type->set_eth_addr(iface, mac);
+}
+
 int iface_add_eth_addr(uint16_t ifid, const struct rte_ether_addr *mac) {
 	struct iface *iface = iface_from_id(ifid);
 	const struct iface_type *type;
@@ -287,6 +303,111 @@ int iface_del_eth_addr(uint16_t ifid, const struct rte_ether_addr *mac) {
 	return type->del_eth_addr(iface, mac);
 }
 
+int iface_set_mtu(uint16_t ifid, uint16_t mtu) {
+	struct iface *iface = iface_from_id(ifid);
+	const struct iface_type *type;
+
+	if (iface == NULL)
+		return -errno;
+
+	if (mtu > gr_config.max_mtu)
+		return errno_set(ERANGE);
+
+	type = iface_type_get(iface->type);
+	assert(type != NULL);
+	if (type->set_mtu != NULL)
+		return type->set_mtu(iface, mtu);
+
+	iface->mtu = mtu;
+	return 0;
+}
+
+int iface_set_up_down(uint16_t ifid, bool up) {
+	struct iface *iface = iface_from_id(ifid);
+	const struct iface_type *type;
+
+	if (iface == NULL)
+		return -errno;
+
+	type = iface_type_get(iface->type);
+	assert(type != NULL);
+	if (type->set_up_down != NULL)
+		return type->set_up_down(iface, up);
+
+	if (!(iface->flags & GR_IFACE_F_UP) && up)
+		iface->flags |= GR_IFACE_F_UP;
+	else if ((iface->flags & GR_IFACE_F_UP) && !up)
+		iface->flags &= ~GR_IFACE_F_UP;
+
+	return 0;
+}
+
+int iface_set_promisc(uint16_t ifid, bool enabled) {
+	struct iface *iface = iface_from_id(ifid);
+	const struct iface_type *type;
+
+	if (iface == NULL)
+		return -errno;
+
+	type = iface_type_get(iface->type);
+	assert(type != NULL);
+	if (type->set_promisc != NULL)
+		return type->set_promisc(iface, enabled);
+
+	if (enabled)
+		return errno_set(EOPNOTSUPP);
+
+	return 0;
+}
+
+int iface_set_allmulti(uint16_t ifid, bool enabled) {
+	struct iface *iface = iface_from_id(ifid);
+	const struct iface_type *type;
+
+	if (iface == NULL)
+		return -errno;
+
+	type = iface_type_get(iface->type);
+	assert(type != NULL);
+	if (type->set_allmulti != NULL)
+		return type->set_allmulti(iface, enabled);
+
+	if (enabled)
+		return errno_set(EOPNOTSUPP);
+
+	return 0;
+}
+
+int iface_add_vlan(uint16_t ifid, uint16_t vlan_id) {
+	struct iface *iface = iface_from_id(ifid);
+	const struct iface_type *type;
+
+	if (iface == NULL)
+		return -errno;
+
+	type = iface_type_get(iface->type);
+	assert(type != NULL);
+	if (type->add_vlan == NULL)
+		return errno_set(EOPNOTSUPP);
+
+	return type->add_vlan(iface, vlan_id);
+}
+
+int iface_del_vlan(uint16_t ifid, uint16_t vlan_id) {
+	struct iface *iface = iface_from_id(ifid);
+	const struct iface_type *type;
+
+	if (iface == NULL)
+		return -errno;
+
+	type = iface_type_get(iface->type);
+	assert(type != NULL);
+	if (type->del_vlan == NULL)
+		return errno_set(EOPNOTSUPP);
+
+	return type->del_vlan(iface, vlan_id);
+}
+
 int iface_destroy(uint16_t ifid) {
 	struct iface *iface = iface_from_id(ifid);
 	const struct iface_type *type;