Switch to Capstone with paired-singles support #206
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riptl
commented
Jul 24, 2022
| if len(insn.operands) > 0 and insn.operands[len(insn.operands)-1].type == CS_OP_IMM: | ||
| op_str = insn.op_str[:insn.op_str.rfind(" ") + 1] | ||
| dest = insn.operands[len(insn.operands)-1].imm - insn.address | ||
| return f"{insn.mnemonic} {op_str}{hex(dest)}" |
Contributor
Author
There was a problem hiding this comment.
Something is weird about this. Seems like Capstone v5 disassembles the jump target of unconditional branches as relative but "bc" opcode branches as absolute.
Contributor
Author
|
Abandoning this, I think we'd rather want to use the ppc750cl stuff or whatever. Who cares about the duct tape as long as it assembles |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've recently added paired-singles support to Capstone in capstone-engine/capstone#1898 and capstone-engine/capstone#1900.
This means we can finally remove some doldisasm wrapper hacks.
It would take too long to wait for a new Capstone release so I've updated pip requirements to point to the latest Capstone v5 commit.
pip install -r requirements.txtwill work as before but now compiles Capstone from source instead of using a binary from PyPI.