Fix random_product() as well

Author: rhettinger

more_itertools/recipes.py

@@ -580,7 +580,7 @@ def random_product(*iterables, repeat=1):
     ``itertools.product(*args, repeat=repeat)``.
 
     """
-    pools = tuple(map(tuple, iterables * repeat))
+    pools = tuple(map(tuple, iterables)) * repeat
     return tuple(map(choice, pools))
 
 

tests/test_recipes.py

@@ -568,6 +568,14 @@ def test_list_with_repeat(self):
         self.assertEqual(len(n), len(nums))
         self.assertEqual(len(m), len(lets))
 
+        r = list(mi.random_product(iter(nums), iter(lets), repeat=100))
+        self.assertEqual(2 * 100, len(r))
+        n, m = set(r[::2]), set(r[1::2])
+        self.assertEqual(n, set(nums))
+        self.assertEqual(m, set(lets))
+        self.assertEqual(len(n), len(nums))
+        self.assertEqual(len(m), len(lets))
+
 
 class RandomPermutationTests(TestCase):
     """Tests for ``random_permutation()``"""