Skip to content

Commit bfe791d

Browse files
Fix hints. (#108)
1 parent a5936dd commit bfe791d

2 files changed

Lines changed: 6 additions & 13 deletions

File tree

lib/file_generator.dart

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -165,13 +165,6 @@ class FileGenerator extends ProtobufContainer {
165165
String get fqname => '.${descriptor.package}';
166166
FileGenerator get fileGen => this;
167167

168-
// Extract the filename from a URI and remove the extension.
169-
String _fileNameWithoutExtension(Uri filePath) {
170-
String fileName = filePath.pathSegments.last;
171-
int index = fileName.lastIndexOf(".");
172-
return index == -1 ? fileName : fileName.substring(0, index);
173-
}
174-
175168
/// Generates all the Dart files for this .proto file.
176169
List<CodeGeneratorResponse_File> generateFiles(OutputConfiguration config) {
177170
if (!_linked) throw new StateError("not linked");

test/generated_message_test.dart

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -194,12 +194,12 @@ void main() {
194194
TestExtremeDefaultValues message = new TestExtremeDefaultValues();
195195

196196
expect(message.utf8String, '\u1234');
197-
expect(message.infDouble, same(double.INFINITY));
198-
expect(message.negInfDouble, same(double.NEGATIVE_INFINITY));
199-
expect(message.nanDouble, same(double.NAN));
200-
expect(message.infFloat, same(double.INFINITY));
201-
expect(message.negInfFloat, same(double.NEGATIVE_INFINITY));
202-
expect(message.nanFloat, same(double.NAN));
197+
expect(message.infDouble, same(double.infinity));
198+
expect(message.negInfDouble, same(double.negativeInfinity));
199+
expect(message.nanDouble, same(double.nan));
200+
expect(message.infFloat, same(double.infinity));
201+
expect(message.negInfFloat, same(double.negativeInfinity));
202+
expect(message.nanFloat, same(double.nan));
203203
expect(message.cppTrigraph, '? ? ?? ?? ??? ??/ ??-');
204204
expect(message.smallInt64.toRadixString(16).toUpperCase(),
205205
'-7FFFFFFFFFFFFFFF');

0 commit comments

Comments
 (0)