Re-add ARM AArch64 support #468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Hmmm. Probably need to nerf some aarch64 cross-builds from oldish Fedora. |
Contributor
|
#469 may be relevant to your interests |
martinezjavier
approved these changes
May 9, 2022
Contributor
martinezjavier
left a comment
martinezjavier
left a comment
There was a problem hiding this comment.
The changes look good to me.
Collaborator
|
Looks OK here, and passes in basic boot testing for me. And we now get reproducibility! 🏆 |
Now that we've got "objcopy --target efi-app-aarch64" and similar, we don't have to go through heroic effort to try to make aarch64 builds work. This patch updates to a gnu-efi branch that has newer aarch64 crt0 code, and makes efi_aarch64_efi.lds be nearly identical to efi_x86_64_efi.lds. Signed-off-by: Peter Jones <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patchset resurrects aarch64 support, using new objcopy options that are in binutils-2.38. Note that the gnu-efi branch changes, and the shim-15.6 branch has several patches on it.