Make remainders of LatestAtResults tag-aware#10005
Merged
Merged
Conversation
grtlr
added
the
exclude from changelog
Contributor
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
grtlr
force-pushed
the
grtlr/tagged-latest-at
branch
from
ac0e345 to
cea2aac
Compare
Wumpf
approved these changes
May 20, 2025
Wumpf
left a comment
Wumpf
left a comment
Member
There was a problem hiding this comment.
love it when a huge refactor starts running out of fuel :)
| }) | ||
| } | ||
|
|
||
| // TODO(#6889): Is this our tagged component endgame? |
| // The order of the components here is important, and checked by `debug_assert_transform_field_order` | ||
| if let Some(translation) = | ||
| results.component_mono_with_log_level::<components::Translation3D>(mono_log_level) | ||
| results.component_mono_with_log_level_by_name::<components::Translation3D>(mono_log_level) |
| ) | ||
| .component_batch::<blueprint_components::VisualizerOverride>() | ||
| .component_batch::<blueprint_components::VisualizerOverride>( | ||
| &blueprint_archetypes::VisualizerOverrides::descriptor_ranges(), |
Member
There was a problem hiding this comment.
sidenote, not so much related to the particular change: Have we any test that VisualizerOverrides (from python) still works? 🤔
Sounds like a thing that could easily break during this whole effort
Member
There was a problem hiding this comment.
left note in tagged component issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related
What
Title and commit history.