Use Display for errors (#1007)

* Lint against formatting errors using Debug `{:?}`

* Use Display for errors

* Lint to use consistent `err` as name for errors

Author: emilk

crates/re_sdk_comms/src/server.rs

@@ -46,7 +46,7 @@ pub fn serve(
                         spawn_client(stream, tx, options);
                     }
                     Err(err) => {
-                        re_log::warn!("Failed to accept incoming SDK client: {err:?}");
+                        re_log::warn!("Failed to accept incoming SDK client: {err}");
                     }
                 }
             }
@@ -66,7 +66,7 @@ fn spawn_client(stream: std::net::TcpStream, tx: Sender<LogMsg>, options: Server
             re_log::info!("New SDK client connected: {:?}", stream.peer_addr());
 
             if let Err(err) = run_client(stream, &tx, options) {
-                re_log::warn!("Closing connection to client: {err:?}");
+                re_log::warn!("Closing connection to client: {err}");
             }
         })
         .expect("Failed to spawn thread");

crates/re_sdk_comms/src/tcp_client.rs

@@ -40,18 +40,15 @@ impl TcpClient {
             match TcpStream::connect(&self.addrs[..]) {
                 Ok(mut stream) => {
                     if let Err(err) = stream.write(&crate::PROTOCOL_VERSION.to_le_bytes()) {
-                        anyhow::bail!(
-                            "Failed to send to Rerun server at {:?}: {err:?}",
-                            self.addrs
-                        );
+                        anyhow::bail!("Failed to send to Rerun server at {:?}: {err}", self.addrs);
                     } else {
                         self.stream = Some(stream);
                         Ok(())
                     }
                 }
                 Err(err) => {
                     anyhow::bail!(
-                        "Failed to connect to Rerun server at {:?}: {err:?}",
+                        "Failed to connect to Rerun server at {:?}: {err}",
                         self.addrs
                     );
                 }
@@ -69,18 +66,12 @@ impl TcpClient {
             re_log::trace!("Sending a packet of size {}…", packet.len());
             if let Err(err) = stream.write(&(packet.len() as u32).to_le_bytes()) {
                 self.stream = None;
-                anyhow::bail!(
-                    "Failed to send to Rerun server at {:?}: {err:?}",
-                    self.addrs
-                );
+                anyhow::bail!("Failed to send to Rerun server at {:?}: {err}", self.addrs);
             }
 
             if let Err(err) = stream.write(packet) {
                 self.stream = None;
-                anyhow::bail!(
-                    "Failed to send to Rerun server at {:?}: {err:?}",
-                    self.addrs
-                );
+                anyhow::bail!("Failed to send to Rerun server at {:?}: {err}", self.addrs);
             }
 
             Ok(())
@@ -93,7 +84,7 @@ impl TcpClient {
     pub fn flush(&mut self) {
         if let Some(stream) = &mut self.stream {
             if let Err(err) = stream.flush() {
-                re_log::warn!("Failed to flush: {err:?}");
+                re_log::warn!("Failed to flush: {err}");
             }
         }
         re_log::trace!("TCP stream flushed.");

crates/re_ui/src/static_image_cache.rs

@@ -12,7 +12,7 @@ impl StaticImageCache {
             .entry(id)
             .or_insert_with(|| {
                 let color_image = load_image_bytes(image_bytes)
-                    .unwrap_or_else(|err| panic!("Failed to load image {id:?}: {err:?}"));
+                    .unwrap_or_else(|err| panic!("Failed to load image {id:?}: {err}"));
                 let retained_img = RetainedImage::from_color_image(id, color_image);
                 Arc::new(retained_img)
             })

crates/re_viewer/src/app.rs

@@ -547,7 +547,7 @@ impl App {
                 let log_db = self.log_dbs.entry(self.state.selected_rec_id).or_default();
 
                 if let Err(err) = log_db.add(msg) {
-                    re_log::error!("Failed to add incoming msg: {:?}", err);
+                    re_log::error!("Failed to add incoming msg: {err}");
                 };
                 if start.elapsed() > instant::Duration::from_millis(10) {
                     egui_ctx.request_repaint(); // make sure we keep receiving messages asap

crates/re_viewer/src/ui/data_ui/log_msg.rs

@@ -122,8 +122,11 @@ impl DataUi for ArrowMsg {
                     ui.end_row();
                 });
             }
-            Err(e) => {
-                ui.label(ctx.re_ui.error_text(format!("Error parsing ArrowMsg: {e}")));
+            Err(err) => {
+                ui.label(
+                    ctx.re_ui
+                        .error_text(format!("Error parsing ArrowMsg: {err}")),
+                );
             }
         }
     }

crates/re_viewer/src/ui/event_log_view.rs

@@ -209,7 +209,7 @@ fn table_row(
                 });
             }
             Err(err) => {
-                re_log::error_once!("Bad arrow payload: {:?}", err);
+                re_log::error_once!("Bad arrow payload: {err}",);
                 row.col(|ui| {
                     ui.label("Bad Arrow Payload".to_owned());
                 });

crates/re_viewer/src/ui/view_spatial/scene/scene_part/arrows3d.rs

@@ -137,7 +137,7 @@ impl ScenePart for Arrows3DPart {
             }) {
                 Ok(_) | Err(QueryError::PrimaryNotFound) => {}
                 Err(err) => {
-                    re_log::error_once!("Unexpected error querying '{:?}': {:?}", ent_path, err);
+                    re_log::error_once!("Unexpected error querying {ent_path:?}: {err}");
                 }
             }
         }

crates/re_viewer/src/ui/view_spatial/scene/scene_part/boxes2d.rs

@@ -144,7 +144,7 @@ impl ScenePart for Boxes2DPart {
             }) {
                 Ok(_) | Err(QueryError::PrimaryNotFound) => {}
                 Err(err) => {
-                    re_log::error_once!("Unexpected error querying '{:?}': {:?}", ent_path, err);
+                    re_log::error_once!("Unexpected error querying {ent_path:?}: {err}");
                 }
             }
         }

crates/re_viewer/src/ui/view_spatial/scene/scene_part/boxes3d.rs

@@ -142,7 +142,7 @@ impl ScenePart for Boxes3DPart {
             }) {
                 Ok(_) | Err(QueryError::PrimaryNotFound) => {}
                 Err(err) => {
-                    re_log::error_once!("Unexpected error querying '{:?}': {:?}", ent_path, err);
+                    re_log::error_once!("Unexpected error querying {ent_path:?}: {err}");
                 }
             }
         }

crates/re_viewer/src/ui/view_spatial/scene/scene_part/cameras.rs

@@ -225,7 +225,7 @@ impl ScenePart for CamerasPart {
             }) {
                 Ok(_) | Err(QueryError::PrimaryNotFound) => {}
                 Err(err) => {
-                    re_log::error_once!("Unexpected error querying '{:?}': {:?}", ent_path, err);
+                    re_log::error_once!("Unexpected error querying {ent_path:?}: {err}");
                 }
             }
         }