Skip to content

Commit cb9a754

Browse files
authored
Fix CMake trying to pick up test folders outside of the Rerun project/zip (#4770)
### What This PR changes the `CMakeLists.txt` of `rerun_cpp` to test for the full path of the `tests` directory to avoid false positives. Closes #4769 ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using newly built examples: [app.rerun.io](https://app.rerun.io/pr/4770/index.html) * Using examples from latest `main` build: [app.rerun.io](https://app.rerun.io/pr/4770/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [app.rerun.io](https://app.rerun.io/pr/4770/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG - [PR Build Summary](https://build.rerun.io/pr/4770) - [Docs preview](https://rerun.io/preview/ebe1d4ba438ffd72329b1b50052bc797917208db/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/ebe1d4ba438ffd72329b1b50052bc797917208db/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
1 parent 65b5077 commit cb9a754

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

rerun_cpp/CMakeLists.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -186,6 +186,6 @@ install(FILES
186186
# -----------------------------------------------------------------------------
187187
# Add tests if they exist (they are not part of the distribution zip).
188188
# Has direct dependency to arrow, so needs to happen last.
189-
if(EXISTS tests)
190-
add_subdirectory(tests)
189+
if(EXISTS ${CMAKE_CURRENT_SOURCE_DIR}/tests)
190+
add_subdirectory(${CMAKE_CURRENT_SOURCE_DIR}/tests)
191191
endif()

0 commit comments

Comments
 (0)