Skip to content

Commit b4dff2b

Browse files
authored
All C++ preprocessor macros start now with RR_ (instead of a mix of RR_ and RERUN_) (#4371)
### What ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [app.rerun.io](https://app.rerun.io/pr/4371) (if applicable) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG - [PR Build Summary](https://build.rerun.io/pr/4371) - [Docs preview](https://rerun.io/preview/cc4b9e350b6b5667dbf9289ecd0444a5acd7a9c8/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/cc4b9e350b6b5667dbf9289ecd0444a5acd7a9c8/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
1 parent 8c9ff59 commit b4dff2b

25 files changed

+118
-116
lines changed

CODE_STYLE.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -204,6 +204,8 @@ To accommodate for this and other languages, strings on the C interface are almo
204204
### Misc
205205
We don't add `inline` before class/struct member functions if they are inlined in the class/struct definition.
206206

207+
Preprocessor directives/macros are usually prefixed with `RR_`
208+
207209
Include what you use: if you use `std::vector`, then include `<vector>` - don't depend on a transitive include.
208210

209211

crates/re_types_builder/src/codegen/cpp/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -442,7 +442,7 @@ impl QuotedObject {
442442
#field_ident = std::move(#parameter_ident);
443443
#NEWLINE_TOKEN
444444
#gcc_ignore_comment
445-
RERUN_WITH_MAYBE_UNINITIALIZED_DISABLED(return std::move(*this);)
445+
RR_WITH_MAYBE_UNINITIALIZED_DISABLED(return std::move(*this);)
446446
},
447447
inline: true,
448448
});

rerun_cpp/src/rerun/archetypes/arrows3d.hpp

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

rerun_cpp/src/rerun/archetypes/asset3d.hpp

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

rerun_cpp/src/rerun/archetypes/boxes2d.hpp

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

rerun_cpp/src/rerun/archetypes/boxes3d.hpp

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

rerun_cpp/src/rerun/archetypes/depth_image.hpp

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

rerun_cpp/src/rerun/archetypes/image.hpp

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

rerun_cpp/src/rerun/archetypes/line_strips2d.hpp

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

rerun_cpp/src/rerun/archetypes/line_strips3d.hpp

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)