Customer archive --app flag not working #654
Open
+5
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
customer archivecommand which was ignoring the--appflag and always returning "Error: no app specified".Problem
The
customer archivecommand defined its own local--appflag that shadowed the global--appflag. This prevented the parent command from properly initializing the app context.Before:
$ replicated customer archive --app myapp customer_123
Error: no app specified
After:
$ replicated customer archive --app myapp customer_123
Customer archived successfully
Solution
--appflag definitionr.appIDfrom the runner context (which is set by the global flag)Changes
cli/cmd/customer_archive.goappvariable and flagarchiveCustomer()function signatureGetCustomerByName(app, ...)toGetCustomerByName(r.appID, ...)Testing
Manual testing verified:
--appflag (previously failed, now works)Build & Tests: