Skip to content

fix: replace delay with setTimeout#23123

Merged
rarkins merged 13 commits into
renovatebot:mainfrom
RahulGautamSingh:replace-delay-with-set-timeout
Jul 6, 2023
Merged

fix: replace delay with setTimeout#23123
rarkins merged 13 commits into
renovatebot:mainfrom
RahulGautamSingh:replace-delay-with-set-timeout

Conversation

@RahulGautamSingh
Copy link
Copy Markdown
Collaborator

Context

Closes: #22606

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@RahulGautamSingh RahulGautamSingh requested a review from viceice July 4, 2023 01:15
Comment thread lib/config/presets/npm/index.spec.ts
Comment thread lib/modules/datasource/npm/index.spec.ts
Comment thread lib/modules/platform/azure/index.spec.ts
@RahulGautamSingh RahulGautamSingh requested a review from viceice July 5, 2023 11:41
Comment thread lib/modules/platform/azure/index.spec.ts
Comment thread lib/modules/platform/bitbucket-server/index.spec.ts Outdated
Comment thread lib/modules/platform/gitlab/index.spec.ts Outdated
Copy link
Copy Markdown
Contributor

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this PR also drop delay from our package.json dependencies?

@rarkins rarkins added this pull request to the merge queue Jul 6, 2023
Merged via the queue into renovatebot:main with commit 8432e76 Jul 6, 2023
@renovate-release
Copy link
Copy Markdown

🎉 This PR is included in version 36.1.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

replace delay with node buildin setTimeout

4 participants