Skip to content

feat: refactor changelog platforms#23076

Merged
viceice merged 4 commits into
renovatebot:mainfrom
setchy:refactor/changelog
Jul 1, 2023
Merged

feat: refactor changelog platforms#23076
viceice merged 4 commits into
renovatebot:mainfrom
setchy:refactor/changelog

Conversation

@setchy

@setchy setchy commented Jul 1, 2023

Copy link
Copy Markdown
Collaborator

Changes

Refactor changelog source logic in preparation for new source types being added.

Context

Split from #22094

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@setchy setchy added type:refactor core:changelogs Related to changelogs/release notes fetching labels Jul 1, 2023
@setchy
setchy requested review from secustor and viceice July 1, 2023 12:48
@setchy
setchy requested a review from rarkins July 1, 2023 13:53

@viceice viceice left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you test on GitHub and gitlab? so everything works as now after merge?

@MindTooth MindTooth left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits.

Comment thread lib/workers/repository/update/pr/changelog/github.spec.ts
Comment thread lib/workers/repository/update/pr/changelog/index.spec.ts
Comment thread lib/workers/repository/update/pr/changelog/source-github.ts
@setchy

setchy commented Jul 1, 2023

Copy link
Copy Markdown
Collaborator Author

did you test on GitHub and gitlab? so everything works as now after merge?

That's correct. Tested with GitHub and GitLab packages - https://github.com/setchy/renovate-changelog-refactor

@setchy

setchy commented Jul 1, 2023

Copy link
Copy Markdown
Collaborator Author

Minor nits.

@MindTooth - let's do that in a separate PR so we correct all nit GitHub permutations

@viceice
viceice added this pull request to the merge queue Jul 1, 2023
@viceice
viceice removed this pull request from the merge queue due to a manual request Jul 1, 2023
@viceice viceice changed the title refactor: changelog sources feat: refactor changelog platforms Jul 1, 2023
@viceice
viceice added this pull request to the merge queue Jul 1, 2023
@viceice

viceice commented Jul 1, 2023

Copy link
Copy Markdown
Member

converted to feature to have a single release, so we can more easily revert if anything goes wrong

Merged via the queue into renovatebot:main with commit 989aa4f Jul 1, 2023
@renovate-release

Copy link
Copy Markdown

🎉 This PR is included in version 35.156.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

core:changelogs Related to changelogs/release notes fetching

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants