Desktop bugs #6385
Merged
Desktop bugs #6385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for reliable-cocada-166884 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| } | ||
|
|
||
| // Check if plugin is already activated | ||
| if (plugin.isActivated()) { |
Collaborator
There was a problem hiding this comment.
Maybe listening on the "activate" event emitted by the manager will be a better solution here.
plugin.on('manager', 'activate', (plugin) => {
....
})
Collaborator
Author
There was a problem hiding this comment.
No that event will be gone
| <HomeTabTitle /> | ||
| <HomeTabRecentWorkspaces plugin={plugin} /> | ||
| {!(platform === appPlatformTypes.desktop) ? <HomeTabRecentWorkspaces plugin={plugin} /> : <HomeTabRecentWorkspacesElectron plugin={plugin} />} | ||
| {/* {!(platform === appPlatformTypes.desktop) ? <HomeTabFile plugin={plugin} /> : <HomeTabFileElectron plugin={plugin}></HomeTabFileElectron>} */} |
Collaborator
There was a problem hiding this comment.
Remove unused comment
Collaborator
Author
There was a problem hiding this comment.
and its already merged
Collaborator
Author
There was a problem hiding this comment.
Removed commented-out code for HomeTabFile component.
|
View your CI Pipeline Execution ↗ for commit 4771e05
☁️ Nx Cloud last updated this comment at |
|
✅ E2E tests passed (workflow: web) Last run: Tue, Oct 28, 2025, 02:19 PM UTC All tests are now passing! Previous failures have been resolved. |
ioedeveloper
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.