Skip to content

Conversation

@markerikson
Copy link
Collaborator

@markerikson markerikson commented Mar 21, 2024

This PR:

  • Fixes the target for the legacy-esm builds, which were somehow set to "esnext" and not "es2017" (totally on me apparently)
  • Adds a missing error message to errors.json

Fixes #4282

@codesandbox
Copy link

codesandbox bot commented Mar 21, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c9110af:

Sandbox Source
rsk-github-issues-example Configuration
@examples-query-react/basic Configuration
@examples-query-react/advanced Configuration
@examples-action-listener/counter Configuration
rtk-esm-cra Configuration

@netlify
Copy link

netlify bot commented Mar 21, 2024

Deploy Preview for redux-starter-kit-docs ready!

Name Link
🔨 Latest commit c9110af
🔍 Latest deploy log https://app.netlify.com/sites/redux-starter-kit-docs/deploys/65fb7a098d27b500081053dc
😎 Deploy Preview https://deploy-preview-4284--redux-starter-kit-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

size-limit report 📦

Path Size

@markerikson markerikson merged commit 41ae39d into master Mar 21, 2024
@markerikson markerikson deleted the bugfix/rtk2-legacy-esm-config branch March 21, 2024 00:10
github-merge-queue bot referenced this pull request in coveo/ui-kit Mar 26, 2024
)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@reduxjs/toolkit](https://redux-toolkit.js.org)
([source](https://togithub.com/reduxjs/redux-toolkit)) | [`2.2.1` ->
`2.2.2`](https://renovatebot.com/diffs/npm/@reduxjs%2ftoolkit/2.2.1/2.2.2)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@reduxjs%2ftoolkit/2.2.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@reduxjs%2ftoolkit/2.2.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@reduxjs%2ftoolkit/2.2.1/2.2.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@reduxjs%2ftoolkit/2.2.1/2.2.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>reduxjs/redux-toolkit (@&#8203;reduxjs/toolkit)</summary>

###
[`v2.2.2`](https://togithub.com/reduxjs/redux-toolkit/releases/tag/v2.2.2)

[Compare
Source](https://togithub.com/reduxjs/redux-toolkit/compare/v2.2.1...v2.2.2)

This patch release fixes an incorrect build setting for the `legacy-esm`
artifacts, and fixes an issue with RTKQ query hooks didn't always remove
the cache entries if arguments were changed rapidly.

#### Changes

##### `legacy-esm` Artifact Transpilation

The `legacy-esm` build artifacts are intended for use by Webpack 4.
Those were *supposed* to be transpiled to target `"es2017"`, but were in
fact still set to target `"esnext"` - an oversight during the 2.0
development cycle. This release fixes that setting, so those artifacts
are now correctly transpiled.

##### Other Fixes

RTKQ query hooks now handle additional actions around argument changes
that should result in cache entries being removed.

Additionally, 2.2.1 contained a fix to an incorrectly named type:
`TypedUseMutationTrigger` is now `TypedMutationTrigger`.

#### What's Changed

- rename TypedUseMutationTrigger to TypedMutationTrigger, and add
deprecated alias by
[@&#8203;EskiMojo14](https://togithub.com/EskiMojo14) in
[https://github.com/reduxjs/redux-toolkit/pull/4204](https://togithub.com/reduxjs/redux-toolkit/pull/4204)
- Fixed memory leak in rapid hook arg changing by
[@&#8203;riqts](https://togithub.com/riqts) in
[https://github.com/reduxjs/redux-toolkit/pull/4268](https://togithub.com/reduxjs/redux-toolkit/pull/4268)
- Fix incorrect legacy-esm target by
[@&#8203;markerikson](https://togithub.com/markerikson) in
[https://github.com/reduxjs/redux-toolkit/pull/4284](https://togithub.com/reduxjs/redux-toolkit/pull/4284)

**Full Changelog**:
reduxjs/redux-toolkit@v2.2.0...v2.2.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/coveo/ui-kit).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
github-merge-queue bot referenced this pull request in valora-inc/wallet Mar 26, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@reduxjs/toolkit](https://redux-toolkit.js.org)
([source](https://togithub.com/reduxjs/redux-toolkit)) | [`^2.2.1` ->
`^2.2.2`](https://renovatebot.com/diffs/npm/@reduxjs%2ftoolkit/2.2.1/2.2.2)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@reduxjs%2ftoolkit/2.2.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@reduxjs%2ftoolkit/2.2.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@reduxjs%2ftoolkit/2.2.1/2.2.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@reduxjs%2ftoolkit/2.2.1/2.2.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>reduxjs/redux-toolkit (@&#8203;reduxjs/toolkit)</summary>

###
[`v2.2.2`](https://togithub.com/reduxjs/redux-toolkit/releases/tag/v2.2.2)

[Compare
Source](https://togithub.com/reduxjs/redux-toolkit/compare/v2.2.1...v2.2.2)

This patch release fixes an incorrect build setting for the `legacy-esm`
artifacts, and fixes an issue with RTKQ query hooks didn't always remove
the cache entries if arguments were changed rapidly.

#### Changes

##### `legacy-esm` Artifact Transpilation

The `legacy-esm` build artifacts are intended for use by Webpack 4.
Those were *supposed* to be transpiled to target `"es2017"`, but were in
fact still set to target `"esnext"` - an oversight during the 2.0
development cycle. This release fixes that setting, so those artifacts
are now correctly transpiled.

##### Other Fixes

RTKQ query hooks now handle additional actions around argument changes
that should result in cache entries being removed.

Additionally, 2.2.1 contained a fix to an incorrectly named type:
`TypedUseMutationTrigger` is now `TypedMutationTrigger`.

#### What's Changed

- rename TypedUseMutationTrigger to TypedMutationTrigger, and add
deprecated alias by
[@&#8203;EskiMojo14](https://togithub.com/EskiMojo14) in
[https://github.com/reduxjs/redux-toolkit/pull/4204](https://togithub.com/reduxjs/redux-toolkit/pull/4204)
- Fixed memory leak in rapid hook arg changing by
[@&#8203;riqts](https://togithub.com/riqts) in
[https://github.com/reduxjs/redux-toolkit/pull/4268](https://togithub.com/reduxjs/redux-toolkit/pull/4268)
- Fix incorrect legacy-esm target by
[@&#8203;markerikson](https://togithub.com/markerikson) in
[https://github.com/reduxjs/redux-toolkit/pull/4284](https://togithub.com/reduxjs/redux-toolkit/pull/4284)

**Full Changelog**:
reduxjs/redux-toolkit@v2.2.0...v2.2.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone
America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone
America/Los_Angeles.

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/valora-inc/wallet).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
shottah referenced this pull request in Kolektivo/Kolektivo-Mobile-App May 15, 2024
)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@reduxjs/toolkit](https://redux-toolkit.js.org)
([source](https://togithub.com/reduxjs/redux-toolkit)) | [`^2.2.1` ->
`^2.2.2`](https://renovatebot.com/diffs/npm/@reduxjs%2ftoolkit/2.2.1/2.2.2)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@reduxjs%2ftoolkit/2.2.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@reduxjs%2ftoolkit/2.2.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@reduxjs%2ftoolkit/2.2.1/2.2.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@reduxjs%2ftoolkit/2.2.1/2.2.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>reduxjs/redux-toolkit (@&#8203;reduxjs/toolkit)</summary>

###
[`v2.2.2`](https://togithub.com/reduxjs/redux-toolkit/releases/tag/v2.2.2)

[Compare
Source](https://togithub.com/reduxjs/redux-toolkit/compare/v2.2.1...v2.2.2)

This patch release fixes an incorrect build setting for the `legacy-esm`
artifacts, and fixes an issue with RTKQ query hooks didn't always remove
the cache entries if arguments were changed rapidly.

#### Changes

##### `legacy-esm` Artifact Transpilation

The `legacy-esm` build artifacts are intended for use by Webpack 4.
Those were *supposed* to be transpiled to target `"es2017"`, but were in
fact still set to target `"esnext"` - an oversight during the 2.0
development cycle. This release fixes that setting, so those artifacts
are now correctly transpiled.

##### Other Fixes

RTKQ query hooks now handle additional actions around argument changes
that should result in cache entries being removed.

Additionally, 2.2.1 contained a fix to an incorrectly named type:
`TypedUseMutationTrigger` is now `TypedMutationTrigger`.

#### What's Changed

- rename TypedUseMutationTrigger to TypedMutationTrigger, and add
deprecated alias by
[@&#8203;EskiMojo14](https://togithub.com/EskiMojo14) in
[https://github.com/reduxjs/redux-toolkit/pull/4204](https://togithub.com/reduxjs/redux-toolkit/pull/4204)
- Fixed memory leak in rapid hook arg changing by
[@&#8203;riqts](https://togithub.com/riqts) in
[https://github.com/reduxjs/redux-toolkit/pull/4268](https://togithub.com/reduxjs/redux-toolkit/pull/4268)
- Fix incorrect legacy-esm target by
[@&#8203;markerikson](https://togithub.com/markerikson) in
[https://github.com/reduxjs/redux-toolkit/pull/4284](https://togithub.com/reduxjs/redux-toolkit/pull/4284)

**Full Changelog**:
reduxjs/redux-toolkit@v2.2.0...v2.2.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone
America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone
America/Los_Angeles.

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/valora-inc/wallet).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

redux-toolkit.legacy-esm.js not actually compatible with Webpack 4 due to optional chaining

2 participants