Allow to prune operators from different catalogs #821

betoredhat · 2025-11-18T22:06:30Z

SUMMARY

Allow prune operators from different catalogs.

ISSUE TYPE

nominal change

Tests

coderabbitai · 2025-11-18T22:06:41Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

Walkthrough

This pull request adds support for pruning operators from multiple source catalogs into a single destination catalog. It includes documentation describing the multi-catalog scenario with code examples and introduces a new task group that processes additional catalogs during the render phase.

Changes

Cohort / File(s)	Summary
Multi-catalog pruning feature `roles/prune_catalog/README.md`	Adds documentation subsection with complete code example demonstrating pruning from multiple source catalogs into one destination, including notes about default catalog field handling and example command outputs
Task implementation `roles/prune_catalog/tasks/main.yml`	Introduces "Render additional catalogs" task group that computes a filtered list of extra catalogs from operators, then loops through each to render via `opm render` with retry logic (3 retries, 10s delay), conditional execution, and lifecycle management

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

The new task logic involves list filtering, loop iteration, and error-handling patterns that warrant careful verification
Retry configuration and conditional execution logic should be validated against intended behavior
Integration with existing render workflow and potential edge cases (empty extra_catalogs, undefined catalog fields) merit attention

Suggested reviewers

tonyskapunk

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main feature addition—enabling pruning of operators from multiple catalogs, which directly aligns with the changes to README documentation and task automation.
Description check	✅ Passed	The description relates to the changeset by identifying it as a nominal change enabling pruning from different catalogs, though it lacks implementation details.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

Provide your own instructions using the high_level_summary_instructions setting.
Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

📝 Description — Summarize the main change in 50–60 words, explaining what was done.

📓 References — List relevant issues, discussions, documentation, or related PRs.

📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.

📊 Contributor Summary — Include a Markdown table showing contributions:
| Contributor | Lines Added | Lines Removed | Files Changed |

✔️ Additional Notes — Add any extra reviewer context.
Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."