OpenShiftAsciiDoc - no alphanumeric charaters in headings #987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 Navigate the preview: https://redhat-documentation-vale-at-red-hat-987.surge.sh 🎊 |
rohennes
force-pushed
the
openshift-asciidoc-headings
branch
from
a27e976 to
dfcd7f6
Compare
Member
|
/lgtm |
aireilly
reviewed
Nov 24, 2025
| message: "Headings should only contain alphanumeric characters." | ||
| nonword: true | ||
| tokens: | ||
| - "^=+\\s+.*[^a-zA-Z0-9\\s\\{\\}'`-].*$" No newline at end of file |
Member
There was a problem hiding this comment.
Suggested change
| - "^=+\\s+.*[^a-zA-Z0-9\\s\\{\\}'`-].*$" | |
| - "^=+\s+.*[^a-zA-Z0-9\s\{\}'`-].*$" |
Collaborator
Author
There was a problem hiding this comment.
Scrapped this version and moving to a tengo script. It was flagging on admonition blocks
Collaborator
Author
There was a problem hiding this comment.
btw, I recall that whatever flavour of regex Value uses required double escapes to work
aireilly
reviewed
Nov 24, 2025
| == No @Symbols! Here | ||
|
|
||
| //vale-fixture | ||
| == No periods. |
Member
There was a problem hiding this comment.
Yes but Something like this is valid and gets caught too:
== Installing the .NET plugin
Collaborator
Author
There was a problem hiding this comment.
Yeah... bit of a clash there I guess. Maybe need an exclusion list. Apparently periods in headings break something in PV1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PV1 fails late in the build process if the headings aren't alphanumeric. It balks at even having periods in them.