Updated changelog for the release 1.19.0 #1094
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datho7561
requested changes
Jul 10, 2025
datho7561
approved these changes
Jul 10, 2025
Contributor
datho7561
left a comment
datho7561
left a comment
There was a problem hiding this comment.
Looks good. Thanks, Muthu!
rgrunber
requested changes
Jul 10, 2025
Member
rgrunber
left a comment
rgrunber
left a comment
There was a problem hiding this comment.
Just a few things I noticed.
| @@ -1,3 +1,25 @@ | |||
| ### 1.19.0 | |||
| - Feat: redhat.vscode-yaml should be able to format docker-compose.yml by default [#1071](https://github.com/redhat-developer/yaml-language-server/issues/1071) | |||
Member
There was a problem hiding this comment.
I wouldn't mention the VS Code extension. Can this just be :
"Feat: Support formatting docker-compose.yml by default".
| ### 1.19.0 | ||
| - Feat: redhat.vscode-yaml should be able to format docker-compose.yml by default [#1071](https://github.com/redhat-developer/yaml-language-server/issues/1071) | ||
| - Feat: Support statically registering format support [#1062](https://github.com/redhat-developer/yaml-language-server/pull/1062) | ||
| - Feat: Support localization in vscode YAML extension [#1081](https://github.com/redhat-developer/yaml-language-server/issues/1081) |
Member
There was a problem hiding this comment.
"Feat: Support localization in the YAML language server"
| - Feat: redhat.vscode-yaml should be able to format docker-compose.yml by default [#1071](https://github.com/redhat-developer/yaml-language-server/issues/1071) | ||
| - Feat: Support statically registering format support [#1062](https://github.com/redhat-developer/yaml-language-server/pull/1062) | ||
| - Feat: Support localization in vscode YAML extension [#1081](https://github.com/redhat-developer/yaml-language-server/issues/1081) | ||
| - Bump: ajv version [#1067](https://github.com/redhat-developer/yaml-language-server/pull/1067) |
Member
There was a problem hiding this comment.
If this is just a dependency update, I would place it near the bottom.
CHANGELOG.md
Outdated
| - Bump: ajv version [#1067](https://github.com/redhat-developer/yaml-language-server/pull/1067) | ||
| - Fix: Invalid tab indentation error [#1110](https://github.com/redhat-developer/vscode-yaml/issues/1110) | ||
| - Fix: Remove Trailing Comma [#1112](https://github.com/redhat-developer/vscode-yaml/issues/1112) | ||
| - Fix: Numbers in comments [#922](https://github.com/redhat-developer/yaml-language-server/issues/922) |
Member
There was a problem hiding this comment.
"Fix: Numbers in comments should not break schema validation"
CHANGELOG.md
Outdated
| - Fix: Validation shows false negative errors if using boolean with const [#1116](https://github.com/redhat-developer/vscode-yaml/issues/1116) | ||
| - Fix: OpenAPI 3.0.0 specification is treated as invalid [#752](https://github.com/redhat-developer/yaml-language-server/issues/752) | ||
| - Fix: YAML Language Server checks against JSON Schema Draft 7 instead of the defined one [#780](https://github.com/redhat-developer/yaml-language-server/issues/780) | ||
| - Fix: Make "Show all Enum on Hover" Optional [#982](https://github.com/redhat-developer/yaml-language-server/issues/982) |
Member
There was a problem hiding this comment.
"optional" should be lowercase.
| - Fix: YAML Language Server checks against JSON Schema Draft 7 instead of the defined one [#780](https://github.com/redhat-developer/yaml-language-server/issues/780) | ||
| - Fix: Make "Show all Enum on Hover" Optional [#982](https://github.com/redhat-developer/yaml-language-server/issues/982) | ||
| - Fix: Fix enum values to be unique [#1028](https://github.com/redhat-developer/yaml-language-server/pull/1028) | ||
| - Fix: yaml conversion does not resolve aliases correctly [#1075](https://github.com/redhat-developer/yaml-language-server/issues/1075) |
Member
There was a problem hiding this comment.
I would make it YAML (uppercase).
Member
|
bah 😜 |
Contributor
Author
|
@rgrunber I will take your point in the YAML changelog.md |
phunguyenmurcul
added a commit
to macrosreply/yaml-language-server
that referenced
this pull request
Oct 3, 2025
* checked const value for the boolean type
* test case added
* added positive test case as well
* Fix corner case for 'flow sequence forbidden' quickfix
- Do not include any trailing spaces in the error range
- This is a change in behaviour; it seems this behaviour was
intentional based on the test cases,
but I don't agree with it, since the error range should only cover
the erroneous code.
- Fix a bug where `]` or `}` are not included in the error range if they're the last character in the document
Fixes redhat-developer#1060
Signed-off-by: David Thompson <[email protected]>
* added dockercompose and github actions in setting handler
Signed-off-by: msivasubramaniaan <[email protected]>
* Fix YAML JSON Schema files starting with %YAML 1.x
Fix a bug where YAML files containing a JSON Schema that start with
%YAML 1.x or a comment that contains a number would fail to to be parsed.
This is caused by the fact that the JSON Schema parser would contain the
number, e.g. 1.2 as the value of `unresolvedJsonSchema.schema` and so
the test for `=== undefined` would fail. This would cause the error from
the JSON parser to be returned instead of trying to parse the file as a
YAML file.
To work around this, also check if `unresolvedJsonSchema.schema` is a
number. It if is, it clearly was not a JSON Schema and so we can safely
try to parse the file as a YAML file.
Fixes: redhat-developer#922
Signed-off-by: David Lechner <[email protected]>
* show the matching value on top
* fix eslint issue
* removed enumMarkdown entries
* Fix bool enums (redhat-developer#1080)
* add (failing) test case for boolean enum and const values
failing with:
```
[
{
code: 1,
data: {
schemaUri: [ 'file:///default_schema_id.yaml' ],
values: [ true, false ]
},
message: 'Value is not accepted. Valid values: true, false.',
range: {
end: { character: 15, line: 0 },
start: { character: 11, line: 0 }
},
severity: 1,
source: 'yaml-schema: file:///default_schema_id.yaml'
}
]
```
* fix the issue for `boolean` values in `enum`
this is the same fix for `enum` that has been applied a while back for `const` values here: redhat-developer@e6165e4
fixes issue: redhat-developer#1078
---------
Co-authored-by: xxx <xxx>
* Support draft-04 schemas (redhat-developer#1065)
This helps to support the schema for openapi 3.0.0,
among others, that use an older draft of JSON schema that has some type
differences that make it incompatible with JSON schema draft 07.
See redhat-developer#1006 , I think the root cause for the issues that PR caused
is that we were trying to download and cache the metaschema from
the "URL" instead of using the copy that's bundled with `ajv`.
Fixes redhat-developer#780, Fixes redhat-developer#752
(and many, many duplicates we'll have to find and clean up)
Signed-off-by: David Thompson <[email protected]>
* Fix recursion bug in ast-conversion (redhat-developer#1076)
* Ensure recursion works as expected
* fix test safety for when parse fails
* use a cache to keep track of resolved aliases
* Added l10n bundle for various language and translate the local strings (redhat-developer#1086)
* added l10n bundle for various language and translate the local strings
* upstream node
* upstream node
* update to node 18
* Changed NodeJS.Timeout as per node 18
* upstream to node 20
* updated coversall script
* fixed test case
* override json service translation
* fixed test cases
* fix/improve enum value descriptions for merged enum lists (redhat-developer#1085)
This is a follow-up submission for redhat-developer#1028, which removes duplicate enum values in merged enum lists.
This fix/improvement ensures that the first **non-empty** enum description is used for the corresponding enum value.
Before this fix: if the first non-unique enum value was not providing a description but the second one was, it was not
picked up and the enum value description stayed empty.
Co-authored-by: xxx <xxx>
Co-authored-by: Muthurajan Sivasubramanian <[email protected]>
* added test cases for bundle and configuration through testhelper class
* Fix array of const completion
* Fix ignoreScalar in value completion
* apply patch
* Updated changelog for the release 1.19.0 (redhat-developer#1094)
* Updated changelog for the release 1.19.0
* updated chhangelog.md
* addressed review comments
* @vscode/l10n is a runtime dependency (redhat-developer#1096)
* check NODE_AUTH_TOKEN is available or not (redhat-developer#1098)
Signed-off-by: msivasubramaniaan <[email protected]>
* Fix auth on npm publish (redhat-developer#1099)
* check NODE_AUTH_TOKEN is available or not
Signed-off-by: msivasubramaniaan <[email protected]>
* set NODE_AUTH_TOKEN
---------
Signed-off-by: msivasubramaniaan <[email protected]>
* Fix auth on npm publish (redhat-developer#1100)
* check NODE_AUTH_TOKEN is available or not
Signed-off-by: msivasubramaniaan <[email protected]>
* set NODE_AUTH_TOKEN
* set npmAuthToken $NODE_AUTH_TOKEN
* set npmAuthToken $NODE_AUTH_TOKEN
---------
Signed-off-by: msivasubramaniaan <[email protected]>
* Update CI.yaml (redhat-developer#1101)
just set token to 123 and check what error occur
* Revert "Update CI.yaml (redhat-developer#1101)" (redhat-developer#1102)
This reverts commit 8c4c22f.
* Fix auth on npm publish (redhat-developer#1103)
* check NODE_AUTH_TOKEN is available or not
Signed-off-by: msivasubramaniaan <[email protected]>
* set NODE_AUTH_TOKEN
* set npmAuthToken $NODE_AUTH_TOKEN
* set npmAuthToken $NODE_AUTH_TOKEN
* all the required parameters are set
---------
Signed-off-by: msivasubramaniaan <[email protected]>
* Fix the fallback path to the l10n folder (redhat-developer#1104)
If the language server client doesn't specify the location of the l10n
folder, then the language server falls back to a path relative to the
complied file.
This path was wrong; `server.js` is in `./out/server/src/server.js`,
so the relative path of the `l10n` folder is `../../../l10n` instead of
`../l10n`.
Signed-off-by: David Thompson <[email protected]>
* Fix the fallback path to the l10n folder (redhat-developer#1104) (redhat-developer#1105)
If the language server client doesn't specify the location of the l10n
folder, then the language server falls back to a path relative to the
complied file.
This path was wrong; `server.js` is in `./out/server/src/server.js`,
so the relative path of the `l10n` folder is `../../../l10n` instead of
`../l10n`.
Signed-off-by: David Thompson <[email protected]>
Co-authored-by: David Thompson <[email protected]>
* Fix NPM broken (redhat-developer#1095)
* set always-auth true
* added registry url and release ci on main push for testing
* removed main push
* renamed to NPM_TOKEN
* used YARN_NPM_AUTH_TOKEN
* used npm_token
* used YARN_NPM_AUTH_TOKEN
* added registry-url
* tried NODE_AUTH_TOKEN
* created .npmrc file
* removed .npmrc
* check NODE_AUTH_TOKEN available or not
* moved the check code on top
* checked NPM_TOKEN
* tried with NODE_AUTH_TOKEN
* Try with NPM instead of YARN
* switch to npm
* removed install command
* fix build issue
* fix build issue
* done pkg fix
* Completely moved to npm from yarn
* review comments addressed
* Bump serialize-javascript and mocha
Bumps [serialize-javascript](https://github.com/yahoo/serialize-javascript) to 6.0.2 and updates ancestor dependency [mocha](https://github.com/mochajs/mocha). These dependencies need to be updated together.
Updates `serialize-javascript` from 6.0.0 to 6.0.2
- [Release notes](https://github.com/yahoo/serialize-javascript/releases)
- [Commits](yahoo/serialize-javascript@v6.0.0...v6.0.2)
Updates `mocha` from 9.2.2 to 11.7.1
- [Release notes](https://github.com/mochajs/mocha/releases)
- [Changelog](https://github.com/mochajs/mocha/blob/main/CHANGELOG.md)
- [Commits](mochajs/mocha@v9.2.2...v11.7.1)
---
updated-dependencies:
- dependency-name: serialize-javascript
dependency-version: 6.0.2
dependency-type: indirect
- dependency-name: mocha
dependency-version: 11.7.1
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <[email protected]>
* Remove coveralls dependency (redhat-developer#1107)
From my understanding, I think we just need the GitHub Action in order
for things to work.
Signed-off-by: David Thompson <[email protected]>
* set .npmrc (redhat-developer#1109)
* add encoding dependency
* upstream @vsode/l10n dependency
* updated changelog.md (redhat-developer#1111)
* Fixed broken link to JSON schema website
* Fix release GitHub Action
- setup-node@v5 creates a .npmrc if you provide a registry,
so there should be no need to do that separately
- after setup-node@v5 is run, `npm publish` expects the token to be
accessible from the environment variable `NODE_AUTH_TOKEN`
- also fix coveralls, because that's getting annoying
(root cause is that it tried to publish the results for each platform
instead of just once)
See https://github.com/actions/setup-node/blob/main/docs/advanced-usage.md#publish-to-npmjs-and-gpr-with-npm
Signed-off-by: David Thompson <[email protected]>
* Fix prerelease publishing
The options that were being used in `npm publish` to modify the version
to include the git hash at the end are intended to be used
with the `npm version` command beforehand instead.
I think this got messed up somewhere along the way while rewriting the
GitHub Action.
Fixes redhat-developer#1128
Signed-off-by: David Thompson <[email protected]>
* Upversion to 1.19.1
We burned the 1.19.0 release by publishing a prerelease version labelled
1.19.0. In order to release, we'll need to use a different version
number.
Signed-off-by: David Thompson <[email protected]>
* Upversion to 1.20.0
* remove \n in README (redhat-developer#1068)
fix typo
Signed-off-by: roc <[email protected]>
Co-authored-by: David Lechner <[email protected]>
* Wrapping code action title with string (redhat-developer#1117)
* Wrapping code action title with string
* adding textedit value field wrapped as string
* README.md: Mention kate as a Client
The `kate` editor has `yaml-language-server` as its default for the YAML format built-in (no plugins or manual configuration needed).
* Support `yaml-textmate` and `yaml-tmlanguage` languages
* redhat-developer/vscode-yaml#1093
* fix: cast cleanupInterval to any before clearing interval
* fix: remove max-warnings option from lint scripts for better flexibility
* Remove @microsoft/eslint-formatter-sarif from devDependencies in package.json
---------
Signed-off-by: David Thompson <[email protected]>
Signed-off-by: msivasubramaniaan <[email protected]>
Signed-off-by: David Lechner <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: roc <[email protected]>
Co-authored-by: msivasubramaniaan <[email protected]>
Co-authored-by: David Thompson <[email protected]>
Co-authored-by: David Lechner <[email protected]>
Co-authored-by: Kosta <[email protected]>
Co-authored-by: David Thompson <[email protected]>
Co-authored-by: pjsk-stripe <[email protected]>
Co-authored-by: Muthurajan Sivasubramanian <[email protected]>
Co-authored-by: ShadiestGoat <[email protected]>
Co-authored-by: Daniel M. Capella <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: debbie <[email protected]>
Co-authored-by: roc <[email protected]>
Co-authored-by: David Lechner <[email protected]>
Co-authored-by: Arunvenmany <[email protected]>
Co-authored-by: Niels Thykier <[email protected]>
Co-authored-by: RedCMD <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changelog.md updated for the release 1.19.0
What issues does this PR fix or reference?
NA
Is it tested? How?
NA