diff --git a/pkg/cmd/kafka/delete/delete.go b/pkg/cmd/kafka/delete/delete.go index 46066a0c3..f30b73bb3 100644 --- a/pkg/cmd/kafka/delete/delete.go +++ b/pkg/cmd/kafka/delete/delete.go @@ -83,7 +83,9 @@ func NewDeleteCommand(f *factory.Factory) *cobra.Command { cmd.Flags().BoolVarP(&opts.force, "yes", "y", false, opts.localizer.MustLocalize("kafka.delete.flag.yes")) cmd.Flags().StringVar(&opts.name, "name", "", opts.localizer.MustLocalize("kafka.delete.flag.name")) - _ = kafkacmdutil.RegisterNameFlagCompletionFunc(cmd, f) + if err := kafkacmdutil.RegisterNameFlagCompletionFunc(cmd, f); err != nil { + opts.Logger.Debug(opts.localizer.MustLocalize("kafka.common.error.load.completions.name.flag"), err) + } return cmd } diff --git a/pkg/cmd/kafka/describe/describe.go b/pkg/cmd/kafka/describe/describe.go index 18aadf848..0b88f9e9a 100644 --- a/pkg/cmd/kafka/describe/describe.go +++ b/pkg/cmd/kafka/describe/describe.go @@ -17,6 +17,7 @@ import ( "github.com/redhat-developer/app-services-cli/pkg/cmd/factory" "github.com/redhat-developer/app-services-cli/pkg/dump" "github.com/redhat-developer/app-services-cli/pkg/kafka" + "github.com/redhat-developer/app-services-cli/pkg/logging" kafkamgmtclient "github.com/redhat-developer/app-services-sdk-go/kafkamgmt/apiv1/client" "github.com/spf13/cobra" "gopkg.in/yaml.v2" @@ -30,6 +31,7 @@ type Options struct { IO *iostreams.IOStreams Config config.IConfig Connection factory.ConnectionFunc + Logger logging.Logger localizer localize.Localizer } @@ -40,6 +42,7 @@ func NewDescribeCommand(f *factory.Factory) *cobra.Command { Config: f.Config, Connection: f.Connection, IO: f.IOStreams, + Logger: f.Logger, localizer: f.Localizer, } @@ -83,7 +86,9 @@ func NewDescribeCommand(f *factory.Factory) *cobra.Command { cmd.Flags().StringVar(&opts.id, "id", "", opts.localizer.MustLocalize("kafka.describe.flag.id")) cmd.Flags().StringVar(&opts.name, "name", "", opts.localizer.MustLocalize("kafka.describe.flag.name")) - _ = kafkacmdutil.RegisterNameFlagCompletionFunc(cmd, f) + if err := kafkacmdutil.RegisterNameFlagCompletionFunc(cmd, f); err != nil { + opts.Logger.Debug(opts.localizer.MustLocalize("kafka.common.error.load.completions.name.flag"), err) + } flagutil.EnableOutputFlagCompletion(cmd) return cmd diff --git a/pkg/cmd/kafka/use/use.go b/pkg/cmd/kafka/use/use.go index 224329a7c..c3566d462 100644 --- a/pkg/cmd/kafka/use/use.go +++ b/pkg/cmd/kafka/use/use.go @@ -66,7 +66,9 @@ func NewUseCommand(f *factory.Factory) *cobra.Command { cmd.Flags().StringVar(&opts.id, "id", "", opts.localizer.MustLocalize("kafka.use.flag.id")) cmd.Flags().StringVar(&opts.name, "name", "", opts.localizer.MustLocalize("kafka.use.flag.name")) - _ = kafkacmdutil.RegisterNameFlagCompletionFunc(cmd, f) + if err := kafkacmdutil.RegisterNameFlagCompletionFunc(cmd, f); err != nil { + opts.Logger.Debug(opts.localizer.MustLocalize("kafka.common.error.load.completions.name.flag"), err) + } return cmd } diff --git a/pkg/localize/locales/en/cmd/kafka_common.en.toml b/pkg/localize/locales/en/cmd/kafka_common.en.toml index cc1e7dbfa..d7d29a644 100644 --- a/pkg/localize/locales/en/cmd/kafka_common.en.toml +++ b/pkg/localize/locales/en/cmd/kafka_common.en.toml @@ -33,3 +33,6 @@ one = 'invalid page number {{.Page}}, minimum value is -1' [kafka.common.validation.size.error.invalid.minValue] one = 'invalid value for size {{.Size}}, minimum value is -1' + +[kafka.common.error.load.completions.name.flag] +one = 'failed to load completions for --name:' \ No newline at end of file